From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v2] t3404-rebase-interactive.sh: fix typos in title of a rewording test
Date: Tue, 12 Sep 2023 17:25:26 -0700 [thread overview]
Message-ID: <xmqq8r9aly15.fsf@gitster.g> (raw)
In-Reply-To: <76c36744-b821-450b-9817-e0cd8811de65@gmail.com> (Phillip Wood's message of "Tue, 12 Sep 2023 14:26:36 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
> On 12/09/2023 11:42, Oswald Buddenhagen wrote:
>> This test was introduced by commit 0c164ae7a ("rebase -i: add another
>> reword test", 2021-08-20). I didn't quite get what it was meant to do,
>> so here's an explanation from Phillip:
>> The purpose of the test is to ensure that
>> (i) There are no uncommited changes when the editor runs. I.e.,
>> we
>> commit without running the editor and then reword by amending
>> that commit. This ensures that we have the same user experience
>> whether or not the commit was fast-forwarded [1].
>> (ii) That the todo list is re-read after the commit has been
>> reworded.
>> This is to allow the user to update the todo list while the rebase
>> is paused for editing the commit message.
>> [1] https://lore.kernel.org/git/20190812175046.GM20404@szeder.dev/
>> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
> This looks good to me, Thanks
>
> Phillip
Thanks, both. Will queue.
prev parent reply other threads:[~2023-09-13 0:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 12:21 [PATCH] t3404-rebase-interactive.sh: fix name of a rewording test Oswald Buddenhagen
2023-09-11 22:36 ` Junio C Hamano
2023-09-12 10:15 ` Phillip Wood
2023-09-12 10:42 ` [PATCH v2] t3404-rebase-interactive.sh: fix typos in title " Oswald Buddenhagen
2023-09-12 11:14 ` Oswald Buddenhagen
2023-09-12 13:26 ` Phillip Wood
2023-09-13 0:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8r9aly15.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).