git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org
Subject: Re: [RFC] New configuration option "diff.statNameWidth"
Date: Sat, 02 Sep 2023 11:47:22 -0700	[thread overview]
Message-ID: <xmqq8r9ommyt.fsf@gitster.g> (raw)
In-Reply-To: <eb8f524eca3975f086715ec32a8a1fbb@manjaro.org> (Dragan Simic's message of "Sat, 02 Sep 2023 20:03:11 +0200")

Dragan Simic <dsimic@manjaro.org> writes:

> I'd like to implement support for a new configuration option named
> "diff.statNameWidth" and submit the patch, so I'd like to check first
> would that patch be accepted and merged.

In general, we do not give promises or estimates.  The devil is in
the details and until we see the design we may not know if an
overall idea is good.  Even when it is obviously a good idea, we
would not know the quality of the implementation until we see it.

 - If something is worth adding, even if we do not accept it in the
   upstream first, it will spread among users and developers, and
   eventually we may realize the mistake of initially not taking it
   and we may come begging to the contributor for upstreaming.

 - On the other hand, a new thing that even the contributor
   themselves are unsure if it is worth investing their work in, if
   it is only to use it for themselves, is very unlikely to be of
   interest to us or our users.

"If this will be accepted, I'll work on it" is a very counter
productive thing to say around here.  It is easily (mis)taken as a
sign that it is the latter case.  "This is a good idea, I believe in
it, and I'll work on it whether you initially show interest or not"
is what we want to see, and such a patch will not need a "check
first" letter.

In other words, make it so good that we would come to you, begging
;-).

Thanks.

  reply	other threads:[~2023-09-02 18:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-02 18:03 [RFC] New configuration option "diff.statNameWidth" Dragan Simic
2023-09-02 18:47 ` Junio C Hamano [this message]
2023-09-02 18:56   ` Dragan Simic
2023-09-02 22:16     ` Junio C Hamano
2023-09-03  3:43       ` Dragan Simic
2023-09-11 18:56         ` Dragan Simic
2023-09-11 23:02           ` Junio C Hamano
2023-09-12  0:26             ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8r9ommyt.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dsimic@manjaro.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).