git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Edmundo Carmona Antoranz <eantoranz@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] sequencer - tipped merge strategy
Date: Mon, 06 Mar 2023 09:32:34 -0800	[thread overview]
Message-ID: <xmqq8rg9bxal.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BGOtsjgfN5f=dSb0ZSEx8nzFs6SKrUm=2TtPPH5cKa4cA@mail.gmail.com> (Elijah Newren's message of "Sat, 4 Mar 2023 12:31:50 -0800")

Elijah Newren <newren@gmail.com> writes:

> Having read the rest of this thread, I notice you pointed out to Junio
> that you want to amend a commit in the history of the merge,
> suggesting you are just modifying the commit message (or maybe
> author/committer info).  More generally, I _think_ your usecase and
> justification for this patch could be worded something like:
>
> """
> We often rebase with `--rebase-merges`, `--interactive`, and
> `--keep-base` (or equivalent command line flags) and only modify
> commit metadata during the rebase.  Since we do not modify any files,
> we would like the rebase to proceed without conflicts.

It makes very much sense to focus on this narrow but useful use
case, and I view it a very natural extension to already existing "if
we just pick without any user interaction a commit on top of its
current base, the we do not do anything, fast-forward and just
pretend we picked it".  IOW, shouldn't it something the sequencer
machinery should be able to do natively without forcing the user to
specify a new merge strategy?


      parent reply	other threads:[~2023-03-06 17:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 14:53 [RFC PATCH] sequencer - tipped merge strategy Edmundo Carmona Antoranz
2023-03-03 16:45 ` Junio C Hamano
2023-03-04 11:45   ` Edmundo Carmona Antoranz
2023-03-04 11:47     ` Edmundo Carmona Antoranz
2023-03-04 20:36       ` Elijah Newren
2023-03-05 13:40         ` Edmundo Carmona Antoranz
2023-03-04 20:31 ` Elijah Newren
2023-03-05 14:00   ` Edmundo Carmona Antoranz
2023-03-06 17:32   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8rg9bxal.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=eantoranz@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).