From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH] fixup! CI: use https, not http to download binaries from perforce.com
Date: Sat, 23 Apr 2022 09:16:31 -0700 [thread overview]
Message-ID: <xmqq8rrv3hcw.fsf@gitster.g> (raw)
In-Reply-To: <20220423154420.32885-1-carenas@gmail.com> ("Carlo Marcelo Arenas Belón"'s message of "Sat, 23 Apr 2022 08:44:20 -0700")
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> Not sure why this is suddently faiing, but this proposed fixup also
> makes both server names consistent and would be easier to clean up
> later.
Yeah, I was wondering why the other one uses a fully hardcoded URL
that these variables do not know about.
Would it make sense to rename LINUX_P4_VERSION to P4_AT_PERFORCE_VERSION
or something and set it also in the macOS section in ci/lib.sh? We have
# The Linux build installs the defined dependency versions below.
# The OS X build installs much more recent versions, whichever
# were recorded in the Homebrew database upon creating the OS X
# image.
# Keep that in mind when you encounter a broken OS X build!
export LINUX_P4_VERSION="16.2"
which if I am reading your series correctly has become stale; we no
longer rely on brew/cask, and do this for macOS identically to what
we do here for Linux.
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> ci/install-dependencies.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 98444821729..b8ace0355e2 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -5,7 +5,7 @@
>
> . ${0%/*}/lib.sh
>
> -P4WHENCE=https://filehost.perforce.com/perforce/r$LINUX_P4_VERSION
> +P4WHENCE=https://cdist2.perforce.com/perforce/r$LINUX_P4_VERSION
> LFSWHENCE=https://github.com/github/git-lfs/releases/download/v$LINUX_GIT_LFS_VERSION
> UBUNTU_COMMON_PKGS="make libssl-dev libcurl4-openssl-dev libexpat-dev
> tcl tk gettext zlib1g-dev perl-modules liberror-perl libauthen-sasl-perl
next prev parent reply other threads:[~2022-04-23 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0220423142559.32507-5-carenas@gmail.com>
2022-04-23 15:44 ` [PATCH] fixup! CI: use https, not http to download binaries from perforce.com Carlo Marcelo Arenas Belón
2022-04-23 16:16 ` Junio C Hamano [this message]
2022-04-23 17:33 ` Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rrv3hcw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox