git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Nika Layzell via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Nika Layzell" <nika@thelayzells.com>
Subject: Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode
Date: Fri, 08 Jan 2021 11:48:57 -0800	[thread overview]
Message-ID: <xmqq8s93i506.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2101081534380.2213@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Fri, 8 Jan 2021 15:56:20 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> But I don't see how that would make this process more inviting to new
> contributors.

Appearing to be inviting should not be our primary goal.  

Instead, the goal should be to make it easier to contribute quality
patches.  By doing so, the smooth experience may attract more new
people, which may end up to be "inviting" in the end, but that is as
a side effect.

> BTW I get the sense that many Git mailing list regulars have this idea
> that making the review process easier for one-time contributors would
> invite too many low-quality contributions.

I don't get such a sense at all.

Sure, if GGG or any other mechanism encourages spamming the list
with low-quality patches, that may harm our productivity, but that
is not what we are doing.  And I do not see how it can be a source
of low-quality contributions to send patches that by default do not
CC them to random people when the sender does not know when it is
appropriate to do so.  Sure, if the patches asked for attention from
appropriate reviewers (the maintainer included), it might get more
responses, but we more often review patches that are only sent to
the list than those that are sent directly to us via Cc _anyway_.

On the other hand, inviting more new people to CC reviewers whose
mailboxes are already full when the patches are not yet ready would
harm productivity of recipients of such patches.

One attribute of a quality patch is that it is CC'ed to the right
people and at the right time.

  reply	other threads:[~2021-01-08 19:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 19:56 [PATCH 0/1] add--interactive: skip index refresh in reset patch mode Nika Layzell via GitGitGadget
2019-11-23 19:56 ` [PATCH 1/1] " Nika Layzell via GitGitGadget
2019-11-24  6:01 ` [PATCH 0/1] " Junio C Hamano
2019-11-25 14:24   ` Johannes Schindelin
2019-11-25 14:45     ` Johannes Schindelin
2019-11-26  1:13       ` Junio C Hamano
2021-01-07 14:18         ` Cc'ing the Git maintainer on GitGitGadget contributions, was " Johannes Schindelin
2021-01-07 14:57           ` Ævar Arnfjörð Bjarmason
2021-01-07 16:20             ` Johannes Schindelin
2021-01-07 21:25               ` Junio C Hamano
2021-01-08 14:56                 ` Johannes Schindelin
2021-01-08 19:48                   ` Junio C Hamano [this message]
2021-01-10 12:02                     ` Johannes Schindelin
2021-01-08 20:08                   ` Taylor Blau
2021-01-10 12:21                     ` Johannes Schindelin
2021-01-10 20:18                       ` Junio C Hamano
2021-01-11 19:18                         ` Taylor Blau
2021-01-12 23:22                           ` Junio C Hamano
2021-01-14  6:32                         ` 胡哲宁
2019-11-26  1:12     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8s93i506.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=nika@thelayzells.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).