git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Abhishek Kumar <abhishekkumar8222@gmail.com>,
	Git List <git@vger.kernel.org>,
	Pierrick Gaudry <pierrick.gaudry@loria.fr>
Subject: Re: [PATCH] commit: silence git-gc if --quiet is given
Date: Wed, 06 May 2020 10:33:16 -0700	[thread overview]
Message-ID: <xmqq8si56k9v.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cSi5xe_FSzr7Z3D6+f1WxsbPthQnWcE1FrLyhrmi4TCGg@mail.gmail.com> (Eric Sunshine's message of "Wed, 6 May 2020 12:09:06 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Wed, May 6, 2020 at 10:03 AM Abhishek Kumar
> <abhishekkumar8222@gmail.com> wrote:
>> As reported by Perrick [1], commit does not propagate quiet behavior to
>> gc if present. While we are at it, convert argv_gc_auto to struct argv_array.
>>
>> [1]: https://lore.kernel.org/git/20200506094327.GC31637@rillettes/
>
> According to the source you cite, this sort of issue has come up
> before in a different context (git-fetch). Do we know if there are
> other commands which invoke git-gc which might also suffer the same
> issue?

I just wrote my analysis to the original thread.  It looks to me a
fairly low-hanging fruit.


      reply	other threads:[~2020-05-06 17:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 14:01 [PATCH] commit: silence git-gc if --quiet is given Abhishek Kumar
2020-05-06 16:09 ` Eric Sunshine
2020-05-06 17:33   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8si56k9v.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=abhishekkumar8222@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pierrick.gaudry@loria.fr \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).