From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] t: drop debug `cat` calls
Date: Mon, 24 Feb 2020 12:49:24 -0800 [thread overview]
Message-ID: <xmqq8skrpv6z.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAN0heSo8RSyvTqTtDLcnBsvMJ-DLL_B-sKRZDNUZBhZ1yX=bmQ@mail.gmail.com> ("Martin Ågren"'s message of "Mon, 24 Feb 2020 21:24:32 +0100")
Martin Ågren <martin.agren@gmail.com> writes:
> For the first patch 1/3, if we lose the cat entirely, we risk bugs in
> *git* being hidden.
Yes, as Peff already said, the change to explicitly test if the file
exists makes perfect sense.
> For the hunk in patch 2/3, I first thought it was in the same
> category, before I realized that kwdelfile.c disappearing would be
> a bug in *p4* as opposed to *git p4*. Since we're not in the
> business of testing/verifying other people's software, we can
> afford to drop that call entirely.
It is ">kwdelfile.c" shell redirection that creates that file. I
agree with you that preparing for a bug that "p4 add -t ktext
kwdelfile.c" or "p4 submit" removes the file is a little too much.
next prev parent reply other threads:[~2020-02-24 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 8:48 [PATCH 1/3] t4117: check for files using `test_path_is_file` Martin Ågren
2020-02-23 8:48 ` [PATCH 2/3] t9810: drop debug `cat` call Martin Ågren
2020-02-24 19:18 ` Junio C Hamano
2020-02-23 8:48 ` [PATCH 3/3] t: drop debug `cat` calls Martin Ågren
2020-02-24 19:32 ` Junio C Hamano
2020-02-24 20:24 ` Martin Ågren
2020-02-24 20:49 ` Junio C Hamano [this message]
2020-02-23 21:46 ` [PATCH 1/3] t4117: check for files using `test_path_is_file` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8skrpv6z.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).