* [PATCH] t3031: update test description to mention desired behavior
@ 2018-08-03 23:09 Elijah Newren
2018-08-03 23:42 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Elijah Newren @ 2018-08-03 23:09 UTC (permalink / raw)
To: git; +Cc: Elijah Newren
This test description looks like it was written with the originally
observed behavior ("causes segfault") rather than the desired and now
current behavior ("does not cause segfault"). Fix it.
Signed-off-by: Elijah Newren <newren@gmail.com>
---
t/t3031-merge-criscross.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh
index e59b0a32d6..3824756a02 100755
--- a/t/t3031-merge-criscross.sh
+++ b/t/t3031-merge-criscross.sh
@@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' '
git branch G
'
-test_expect_success 'recursive merge between F and G, causes segfault' '
+test_expect_success 'recursive merge between F and G does not cause segfault' '
git merge F
'
--
2.18.0.548.gcd835b18f7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] t3031: update test description to mention desired behavior
2018-08-03 23:09 [PATCH] t3031: update test description to mention desired behavior Elijah Newren
@ 2018-08-03 23:42 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2018-08-03 23:42 UTC (permalink / raw)
To: Elijah Newren; +Cc: git
Elijah Newren <newren@gmail.com> writes:
> This test description looks like it was written with the originally
> observed behavior ("causes segfault") rather than the desired and now
> current behavior ("does not cause segfault"). Fix it.
GOod.
>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
> t/t3031-merge-criscross.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh
> index e59b0a32d6..3824756a02 100755
> --- a/t/t3031-merge-criscross.sh
> +++ b/t/t3031-merge-criscross.sh
> @@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' '
> git branch G
> '
>
> -test_expect_success 'recursive merge between F and G, causes segfault' '
> +test_expect_success 'recursive merge between F and G does not cause segfault' '
> git merge F
> '
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-03 23:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-03 23:09 [PATCH] t3031: update test description to mention desired behavior Elijah Newren
2018-08-03 23:42 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).