Re: [PATCH 01/15] rebase -i: handle NULL value for rebase.missingCommitsCheck

[Junio C Hamano <gitster@pobox.com>]

Phillip Wood <phillip.wood123@gmail.com> writes:

>> A rebase.missingCommitsCheck without a value, as in
>> 
>>    [rebase]
>>    missingCommitsCheck
>> 
>> or "git -c rebase.missingCommitsCheck", makes "git rebase -i"
>> segfault as it writes the todo list: get_missing_commit_check_level()
>> passes the NULL value to strcasecmp().
>> 
>> The setting takes "ignore", "warn" or "error", not a bool. Read it
>> with repo_config_get_string_tmp(), which rejects a missing value with
>> config_error_nonbool(), as ba176db511 (config: handle NULL value when
>> parsing non-bools, 2023-12-07) did for other settings.
>
> If the user sets an invalid value for this config option then we print a 
> warning and default to "ignore". It would seem reasonable to me to do 
> the same for a missing value rather than erroring out.

Interesting point.  I think ignoring a textual invalid value is
mostly for future-proofing (a configuration item written for newer
version of Git added while trying it out is seen by the version of
Git the user regularly uses).  It may be arguable if warn-and-ignore
is the most sensible option, but I fully agree with you that
behaving exactly the same way on valueless true, which is not a
valid setting for the current version of Git, would be a sensible
thing to do.

It seems with your and Derrick's review, this is the only thing that
needs to be updated in v2?

Thanks.