From: Junio C Hamano <gitster@pobox.com>
To: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5 1/3] t4001: modernize
Date: Tue, 22 Sep 2026 12:41:56 -0700 [thread overview]
Message-ID: <xmqqa4p9dqez.fsf@gitster.g> (raw)
In-Reply-To: <20260922143119.3313620-2-markchucarroll@fastmail.com> (Mark C. Chu-Carroll's message of "Tue, 22 Sep 2026 10:31:17 -0400")
"Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
> Old tests were written in a different style than modern
> ones; for better readability and test error messages,
> update t4001 to the modern style.
>
> * run everything inside of a test_expect_success block.
> * write title line on the same line as test_expect_success,
> end that line with a single quote that opens the body of the test,
> and end the test with a single quote that closes the body.
> * write expected output of a test to a file named "expect",
> and actual output to a file named "actual".
> * write here-docs using "<<-" syntax, so that they're indented
> uniformly with the rest of the test.
> * make test names more clearly reflect the functionality that
> they test.
>
> Signed-off-by: Mark C. Chu-Carroll <markchucarroll@fastmail.com>
> ---
> t/t4001-diff-rename.sh | 91 +++++++++++++++++-----------------------
> t/t4009-diff-rename-4.sh | 54 ++++++++++++------------
> 2 files changed, 66 insertions(+), 79 deletions(-)
Rebase glitch? The claim above is that this is about updating t4001
but it seems that a half of t4009 updates are mixed in.
next prev parent reply other threads:[~2026-09-22 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 14:31 [PATCH v5 0/3] t40*: modernize Mark C. Chu-Carroll
2026-09-22 14:31 ` [PATCH v5 1/3] t4001: modernize Mark C. Chu-Carroll
2026-09-22 19:41 ` Junio C Hamano [this message]
2026-09-22 14:31 ` [PATCH v5 2/3] t4009: modernize Mark C. Chu-Carroll
2026-09-22 14:31 ` [PATCH v5 3/3] t4010: modernize Mark C. Chu-Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa4p9dqez.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=markchucarroll@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox