Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Amogh Dambal <amoghdambal1@gmail.com>,  Jeff King <peff@peff.net>,
	Michael Montalbo <mmontalbo@gmail.com>,
	 git@vger.kernel.org
Subject: Re: Expected test suite behavior
Date: Tue, 26 May 2026 10:11:59 +0900	[thread overview]
Message-ID: <xmqqa4tnnfds.fsf@gitster.g> (raw)
In-Reply-To: <ahTsTDhVPkHTEbB_@fruit.crustytoothpaste.net> (brian m. carlson's message of "Tue, 26 May 2026 00:41:48 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> I think I know what the problem is: you're running as root.  I suspect
> `test -x` in the test says that you have permission to execute it
> because you're root and root always ignores permissions.  My guess is
> that most of the tests you're failing have to do with permissions of
> some sort that are being ignored because you're privileged.

I know !SANITY defeats a-rw and lets the tester read or write to the
path, but this is the first time I heard that !SANITY defeats a-x
and lets the tester _execute_ it.

I do not think we drop POSIXPERM prereq when !SANITY automatically,
and I do not think we should, but we should probably have an
automated check to drop POSIXPERM?

    (
	# is an unexecutable look to the user as executable?
	umask 0; >testfile; chmod a-w testfile; test -x testfile;
	status=$?;
	rm -f testfile; exit $status
    )

> I'll just note that if you just want to do Git development, macOS is a
> fully supported platform on which to do that.  I will admit most of the
> major contributors (with the notable exception of the Git for Windows
> maintainer) do use Linux and of course I like and endorse Debian, but
> macOS should build and run just fine if you prefer that.

Hear hear.

We want to encourage developers to do more _native_ development on
their own system, and this is not limited to macOS.  As long as
users on a particular platform rely on working Git there, we are
better off if we have more people actively using that platform to
build, test, develop on, and debug Git for their own use.

Thanks.


  reply	other threads:[~2026-05-26  1:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  6:20 Expected test suite behavior Michael Montalbo
2026-05-25  7:27 ` Jeff King
2026-05-25 22:01   ` Amogh Dambal
2026-05-25 22:18     ` brian m. carlson
2026-05-25 22:25       ` Amogh Dambal
2026-05-26  0:41         ` brian m. carlson
2026-05-26  1:11           ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-25  5:38 Amogh Dambal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa4tnnfds.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=amoghdambal1@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mmontalbo@gmail.com \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox