From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833483A8F7 for ; Sat, 18 Oct 2025 15:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760802274; cv=none; b=hu/YW/xLbAhPR9Fqddy0lNAp6XvFm0Dh+k+ibIUeCMOQWB/r+hHSbAj0mxEaeMtM4mylSIoOp2bztUS1izStWXXhv4JZoYAxAORF8VO3tGnZlfE0fvOogyIiHztLYFRHnUwu8DeAR5kC6XEFgA2//ySHtupxPpUu8nA93IdDejc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760802274; c=relaxed/simple; bh=rgr3NZr9ypqKOBtOfKf4c8yDUmBmU24Nz08o+NSpSKo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=rgexXJaFLHpJkwgvHvvMn7xZJR2o/YQkMFa25jOtpehetFAKfrYRkIr1FoFBNKHVLtVQyf3WSozxOfN72ErxVZpwlBnFmL7ZZAeZPcgbpMqTciltrcFIhG6/i+8mVnk95dgeEfTFfoZalJttqwn41tMvU5qwhM+DQjv4Hd+1ZuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=H41IT93j; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=tc0LBdvv; arc=none smtp.client-ip=202.12.124.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="H41IT93j"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tc0LBdvv" Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id A1C011D00097; Sat, 18 Oct 2025 11:44:31 -0400 (EDT) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-01.internal (MEProxy); Sat, 18 Oct 2025 11:44:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1760802271; x=1760888671; bh=ng3umn9KHQo/eudSsxv9Ld6eTpcL+qs5cwI2r+HAHR8=; b= H41IT93j4h+pk9M0039pCAmFZyL0BsRFhe4sAKH6eBSlbdOCJYQBhIcTNMbyFLWC DqyMULqluL7vBWGICxfyWYhdxhHcSEZ32O4apA3p6B1IuN5q3I7tR0oULRSUsuq6 f3ptNmUu5s7bfjQVIl0VTZggqeZ6CB5GMrYLkjWBKLiZfdrtr3QjRRUpEw4E1Vwa ksPiEwz2p7AOTV4hThRVdAF+wADQFR4FvCL/zPrRcbX539VoU1I5MHFGUKQFzzIZ K/enoXhR4pAqoaT44qaZbv0pvAXzWC1IusTXew98gIr4lH8SpEsmbyNj/iGQxQwB nk7QXXR0TgG6wnoTD2Qr+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1760802271; x= 1760888671; bh=ng3umn9KHQo/eudSsxv9Ld6eTpcL+qs5cwI2r+HAHR8=; b=t c0LBdvvf+ZcwXfe7Jmx+/azor+hYN08mXeX38cRhqVgDQ077n2M7jkv+rAXtnCMm 7gOUgotZeiHIajY7pgRCeMwKJB/CHAbrHudvQC9nIuleAryf947QcNMWClDs1uma aRNmoG6vYP0Wo1xgqG/BWb67WxvDWHwSmw9fkQxRXjwSFrwtc41qFpTHWwIiQqxK RXhGvJ+lrENs28MMSfusON6KILzAwdiPDkwNtyeyWdBQ9GvMYCzKrl1OXi3+TKb8 BaXN8lJzIo2sVwH1WXx7UKX4L8WMuGg6XtkATi3fBBlRTurbuVs5If5fYCamhiQm t8lFIDSF95bfdvwlK0j6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddufedvgeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhnihho ucevucfjrghmrghnohcuoehgihhtshhtvghrsehpohgsohigrdgtohhmqeenucggtffrrg htthgvrhhnpedtffdvteegvddtkeetfeevueevlefgkeefheeigfehveehvdekheelveev fedtheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hgihhtshhtvghrsehpohgsohigrdgtohhmpdhnsggprhgtphhtthhopeehpdhmohguvgep shhmthhpohhuthdprhgtphhtthhopeihlhguhhhomhgvvdguvdesghhmrghilhdrtghomh dprhgtphhtthhopehpvghffhesphgvfhhfrdhnvghtpdhrtghpthhtohepghhithhgihht ghgrughgvghtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepghhithesvhhgvghrrdhkvg hrnhgvlhdrohhrghdprhgtphhtthhopehgihhtshhtvghrsehpohgsohigrdgtohhm X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Oct 2025 11:44:30 -0400 (EDT) From: Junio C Hamano To: Lidong Yan , Jeff King Cc: Lidong Yan via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH] diff: stop output garbled message in dry run mode In-Reply-To: <20251018094722.GC1060824@coredump.intra.peff.net> (Jeff King's message of "Sat, 18 Oct 2025 05:47:22 -0400") References: <6C994C9C-0034-46D0-8112-FF88773B5CF5@gmail.com> <20251018094722.GC1060824@coredump.intra.peff.net> Date: Sat, 18 Oct 2025 08:44:29 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Jeff King writes: > On Sat, Oct 18, 2025 at 09:11:34AM +0800, Lidong Yan wrote: > >> > Test that exercises "git diff -I" is in line with what the >> > original b55e6d36eb wanted to address, but given that we saw a >> > recent regression report like [*], I would have liked to see "git >> > diff --quiet" in the test as well. >> >> I will read Peff’s test and see if I should also add some similar tests > > What I was hoping was that we'd apply my patch, as a matter of release > engineering (backing out the regression-causing bit of b55e6d36eb). And > then you could make more-specific fixes on top (since -I would still > have potential problems). And then you don't need to add a test for the > regression case, since it's already there. Yup, that matches my expectation more closely, which is * We'll do the "send to /dev/null as we used to do before the dry-run thing" on the 'maint' front, which will be merged up to 'master' and above. * We'll queue "here are fixes to the recently introduced dry-run code" (without the /dev/null thing mixed in), and cook that in the usual 'seen' down to 'next' down to 'master' route. In a distant future, we may consider removing the /dev/null thing once the dry-run code path proves to be stable and robust. Thanks.