From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C506E2165E2 for ; Wed, 9 Jul 2025 16:26:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752078386; cv=none; b=c4LWLrV2V0iq4CYymNMCriV+t2Wz77RW99A10r9BfRIF4ywkkh4pHCN4QX2MScV6h4v2WvMJ/XKuN9EgwXlsvd60Dup9GkEK8mjqUF4artC8Y3dOHYu+6aRkpe+Io9ok+9GMYv0T0wLmHe8QE73sCCmEOTUfEdbN/XpehDS45GU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752078386; c=relaxed/simple; bh=P4VeH71m/9gA5gxtDsoNwRWdAK3jTjqshOIgSTrgTT8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=P2WjkjD9lNs5sHSWNChuH8iQ1MfTmZ92XZak3/Gkb6CHnOS3K+gx6IpTmbLcfWzBVmefUmMsNBwvfQfPtfnEtvK95qn04jazWv2ahMiRXPfX+NS4F+kbv1wQz0H8NVsh4QK6RkLK1hG7Hvioi5AY1pwWFhIKVkkcUQ358jh9kzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=kRGqBSQ+; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Yk46u1o2; arc=none smtp.client-ip=103.168.172.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="kRGqBSQ+"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Yk46u1o2" Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id D55F91400395; Wed, 9 Jul 2025 12:26:23 -0400 (EDT) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-09.internal (MEProxy); Wed, 09 Jul 2025 12:26:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1752078383; x=1752164783; bh=7YMeGGlTt3dgDsQJGmTiwpcdnzeSRLkP2Gk07bWyKJo=; b= kRGqBSQ+yRmYwiBiMdi9eK2DaNVrjO7rZPbEVLGzvjERG6BOYW05jTuxO2bx1o/S f9gCl1i8Pbo/Saw4Oz0EqL4+ep98B7vRCb6kS8dXwl0N5p03UUIwJUYbFMSSyR+B Yc+VDIReKJh1iwVrS0nTPish/O7ZptLbiwpT5aZi41QufZQIMGRA9PDPRc8VPbfO T8my+c/DjbhjjXRf+B38VATdst3pYZSr1iSPqq7Cdm/bB0XJvpA1p287OJIZIVHb WIgE5dVW6OYfbGW/WOtucZWnja+A1IMc0CO6P57i3t5GqJ+W5sWrS6c8iMaJzBSo E7+gD9mko32PW/xKAVPNPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1752078383; x= 1752164783; bh=7YMeGGlTt3dgDsQJGmTiwpcdnzeSRLkP2Gk07bWyKJo=; b=Y k46u1o2Lk6wb73YZDfqdFpSD6F7k/Pr/VBExqVmpI4Vusom47x7qZ39deAtwcR2s lnhuEfEy3NYHvqDf7FEkO8DrK84sm5UWQtOEMBPJjbiIjKfZstoj22iXIiDYO+Wa 9x4Sb14+mDx/VAiqlmqnIhVZq43TtWYXXFbFJktT+IdLfCxJnLTUAptugiQp5zBX OZHyBPxsuQ8asxReb/hvTwejJ0ZqoQhqVCn1X74yMqYsHwKF0LwuZe7y/oOW7jac FJDx98MrMAsOPeTML4Bd+LUjbsBK8lXcefQEErYCBPB2aLhPq4ROMLyMHqQqXn6m L4hHz/sFmkQ6KFx6LnCCA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdefkedtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfgfgggtgfesthekredttderjeenucfhrhhomheplfhunhhiohcu vecujfgrmhgrnhhouceoghhithhsthgvrhesphhosghogidrtghomheqnecuggftrfgrth htvghrnheptdffvdetgedvtdekteefveeuveelgfekfeehiefgheevhedvkeehleevveef tdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepgh hithhsthgvrhesphhosghogidrtghomhdpnhgspghrtghpthhtohephedpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtoheptggrrhgvnhgrshesghhmrghilhdrtghomhdprhgtph htthhopehgihhtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepjheithes khgusghgrdhorhhgpdhrtghpthhtohepphhhihhllhhiphdrfihoohguuddvfeesghhmrg hilhdrtghomhdprhgtphhtthhopehgihhtshhtvghrsehpohgsohigrdgtohhm X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Jul 2025 12:26:23 -0400 (EDT) From: Junio C Hamano To: Carlo Marcelo Arenas =?utf-8?Q?Bel=C3=B3n?= Cc: git@vger.kernel.org, j6t@kdbg.org, phillip.wood123@gmail.com Subject: Re: What's cooking in git.git (Jul 2025, #02; Mon, 7) In-Reply-To: ("Carlo Marcelo Arenas =?utf-8?Q?Bel=C3=B3n=22's?= message of "Wed, 9 Jul 2025 03:41:13 -0700") References: Date: Wed, 09 Jul 2025 09:26:22 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Carlo Marcelo Arenas Belón writes: > On Mon, Jul 07, 2025 at 05:11:12PM -0800, Junio C Hamano wrote: >> >> * cb/daemon-reap-children (2025-06-26) 4 commits >> - daemon: explicitly allow EINTR during poll() >> - daemon: use sigaction() to install child_handler() >> - compat/mingw: allow sigaction(SIGCHLD) >> - compat/posix.h: track SA_RESTART fallback >> >> Futz with SIGCHLD handling in "git daemon". >> >> Stalled? >> cf. >> source: > > I don't think so, but definitely missing reviews (specially for patch 2) That is what I called Stalled---stalling does not have to be due to author's inaction. > and slightly controversial. > ... > On the rationale on why this is independently useful, note that we are > currently relying in at least 2 "unspecified" behaviours: > > 1) using signal() means that it is implementation defined if SA_RESTART > will be enabled or not for that signal, and > 2) if SA_RESTART is enabled, it is implementation defined if we might get > interrupted in poll(). > > both are resolved by using sigaction() instead, and it is up to us to > decide if SA_RESTART is enabled or not (which might make patch 4 obsolete > if we decide against). > > Carlo > > CC: Johannes Sixt on feedback for SIGCHLD in mingw which uses 17 instead > of 22 (cygwin and others) and therefore seem to cause signal to err > without setting errno as it should. Thanks.