From: Junio C Hamano <gitster@pobox.com>
To: "Julian Swagemakers" <julian@swagemakers.org>
Cc: "Aditya Garg" <gargaditya08@live.com>, <git@vger.kernel.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
<sandals@crustytoothpaste.net>, "Zi Yao" <ziyao@disroot.org>,
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH v2] send-email: try to get fqdn by running hostname --fqdn on Linux and macOS
Date: Mon, 12 May 2025 09:42:08 -0700 [thread overview]
Message-ID: <xmqqa57hvl0f.fsf@gitster.g> (raw)
In-Reply-To: <D9U0KAX6KVXK.WCY7YGX2Q0A5@swagemakers.org> (Julian Swagemakers's message of "Mon, 12 May 2025 09:46:05 +0200")
"Julian Swagemakers" <julian@swagemakers.org> writes:
> There are multiple implementations of the hostname command, and they
> don't all support `--fqdn`. For example this will not work on Alpine
> Linux as well as macOS.
> ...
> All seem to support `-f` though, maybe that would be the better option.
What makes me worried about such a proposed changes is if there are
implementations that takes `-f` but uses it to mean something
completely different from fqdn, and emits something that looks like
a hostname but is not. At least an implementation that takes --fqdn
without erroring out would try to give what this code wants to find
out (or it is simply crazy), but -f does not feel specific enough.
next prev parent reply other threads:[~2025-05-12 16:42 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 13:54 [PATCH 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-04 13:54 ` [PATCH 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-04 14:22 ` Kristoffer Haugsbakk
2025-05-04 15:26 ` Aditya Garg
2025-05-04 16:05 ` Kristoffer Haugsbakk
2025-05-04 13:54 ` [PATCH 2/3] docs: improve send-email documentation Aditya Garg
2025-05-04 13:54 ` [PATCH 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-05 6:16 ` [PATCH v2 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-05 6:16 ` [PATCH v2 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-05 6:16 ` [PATCH v2 2/3] docs: improve send-email documentation Aditya Garg
2025-05-05 19:20 ` Junio C Hamano
2025-05-05 19:30 ` Aditya Garg
2025-05-05 6:16 ` [PATCH v2 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-05 15:23 ` [PATCH v3 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-05 15:23 ` [PATCH v3 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-05 23:49 ` Junio C Hamano
2025-05-06 5:38 ` Aditya Garg
2025-05-06 9:35 ` Aditya Garg
2025-05-06 16:50 ` Aditya Garg
2025-05-06 21:59 ` Junio C Hamano
2025-05-06 17:11 ` Junio C Hamano
2025-05-06 17:23 ` Aditya Garg
2025-05-06 17:49 ` Aditya Garg
2025-05-06 22:07 ` Junio C Hamano
2025-05-05 15:23 ` [PATCH v3 2/3] docs: improve send-email documentation Aditya Garg
2025-05-05 23:54 ` Junio C Hamano
2025-05-06 5:36 ` Aditya Garg
2025-05-05 15:23 ` [PATCH v3 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-07 12:33 ` [PATCH v4 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-07 12:33 ` [PATCH v4 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-07 12:48 ` Aditya Garg
2025-05-07 22:42 ` Junio C Hamano
2025-05-08 10:38 ` Aditya Garg
2025-05-07 12:33 ` [PATCH v4 2/3] docs: improve send-email documentation Aditya Garg
2025-05-07 22:21 ` Junio C Hamano
2025-05-08 3:29 ` Aditya Garg
2025-05-08 13:33 ` Junio C Hamano
2025-05-08 13:52 ` Aditya Garg
2025-05-08 16:23 ` Junio C Hamano
2025-05-08 16:38 ` Aditya Garg
2025-05-08 14:52 ` Junio C Hamano
2025-05-08 15:05 ` Aditya Garg
2025-05-08 15:08 ` Aditya Garg
2025-05-07 12:33 ` [PATCH v4 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-08 15:18 ` [PATCH v6 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-08 15:18 ` [PATCH v6 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-08 15:18 ` [PATCH v6 2/3] docs: improve send-email documentation Aditya Garg
2025-05-08 15:18 ` [PATCH v6 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-08 17:14 ` [PATCH v7 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-08 17:14 ` [PATCH v7 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-08 17:14 ` [PATCH v7 2/3] docs: improve send-email documentation Aditya Garg
2025-05-08 17:14 ` [PATCH v7 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-08 18:08 ` [PATCH v7 0/3] Improve checks for valid_fqdn in send-email and update documentation Junio C Hamano
2025-05-09 16:49 ` [PATCH] send-email: try to get fqdn by running hostname --fqdn on Linux and macOS Aditya Garg
2025-05-09 20:13 ` Junio C Hamano
2025-05-10 7:37 ` [PATCH v2] " Aditya Garg
2025-05-12 7:46 ` Julian Swagemakers
2025-05-12 7:49 ` Aditya Garg
2025-05-12 16:42 ` Junio C Hamano [this message]
2025-05-12 16:46 ` Aditya Garg
2025-05-12 17:34 ` Junio C Hamano
2025-05-12 17:42 ` Aditya Garg
2025-05-12 19:05 ` Eric Sunshine
2025-05-12 20:15 ` Junio C Hamano
2025-05-13 12:28 ` Aditya Garg
2025-05-12 13:32 ` Junio C Hamano
2025-05-12 8:11 ` [PATCH v3] send-email: try to get fqdn by running hostname -f " Aditya Garg
2025-05-12 17:16 ` [PATCH v4] " Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa57hvl0f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=gargaditya08@live.com \
--cc=git@vger.kernel.org \
--cc=julian@swagemakers.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).