git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	 git@vger.kernel.org, peff@peff.net,  piotrsiupa@gmail.com
Subject: Re: [PATCH] t3706: Add test for wildcard vs literal pathspec
Date: Wed, 16 Apr 2025 06:11:59 -0700	[thread overview]
Message-ID: <xmqqa58gjlnk.fsf@gitster.g> (raw)
In-Reply-To: <CA+rGoLfAidyuomeNym5WX8Bo7-jPcfHx35wDeZ7W2aorAN-B7g@mail.gmail.com> (JAYATHEERTH K.'s message of "Wed, 16 Apr 2025 07:26:26 +0530")

JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com> writes:

> I think something like git commit "*" -m "Test" also would be a great test
> or even git rm command.

Yes, there are things other than "git add" that  take pathspec (even
"git ls-files" does so), and demonstrating the blast radious of the
existing "bug" you fixed, with how they behave differently and
better with your fix, would be a good thing to do.

But make sure you follow "dashed options first, then other args"
convention.  I do not offhand know (and *MORE* *IMPORTANTLY*, I do
not want anybody to depend on) what the current command line parser
happens to do to

        git commit "*" -m "Test"

If you meant to say that a pathspec with glob, always write it the
right way:

	git commit -m "Test" -- "*"

> About the windows question, I think I will see if there is any common
> ground I could find
> But until then I think prereq is a great option.

The FUNNYNAMES prereq was invented to mark tests that rely on
filesystem being able to handle certain letters, so that may be a
good thing to use.

  reply	other threads:[~2025-04-16 13:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-12  9:46 [PATCH 0/1] add: fix pathspec handling when literal filenames match wildcard K Jayatheerth
2025-04-12  9:46 ` [PATCH 1/1] add: fix handling literal filenames and wildcards K Jayatheerth
2025-04-12 17:40   ` [PATCH] t3706: Add test for wildcard vs literal pathspec K Jayatheerth
2025-04-14 16:51     ` Lucas Seiki Oshiro
2025-04-14 17:08       ` JAYATHEERTH K
2025-04-14 21:42     ` Junio C Hamano
2025-04-15 22:32     ` brian m. carlson
2025-04-16  1:56       ` JAYATHEERTH K
2025-04-16 13:11         ` Junio C Hamano [this message]
2025-04-16 14:49           ` JAYATHEERTH K
2025-04-16 15:49             ` Lucas Seiki Oshiro
2025-04-16 16:00               ` Junio C Hamano
2025-04-19  4:59                 ` JAYATHEERTH K
2025-04-19 17:43                   ` Lucas Seiki Oshiro
2025-04-22 11:57                     ` JAYATHEERTH K
2025-04-16 16:40               ` JAYATHEERTH K
2025-04-16 16:43                 ` JAYATHEERTH K
2025-04-12 15:45 ` [PATCH 0/1] add: fix pathspec handling when literal filenames match wildcard Lucas Seiki Oshiro
2025-04-12 17:34   ` JAYATHEERTH K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa58gjlnk.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jayatheerthkulkarni2005@gmail.com \
    --cc=peff@peff.net \
    --cc=piotrsiupa@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).