git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH 0/1] Fix netrc usage with WebDAV-based HTTP protocol
Date: Mon, 24 Feb 2025 08:46:29 -0800	[thread overview]
Message-ID: <xmqqa5ab70ka.fsf@gitster.g> (raw)
In-Reply-To: <20250223015331.588161-1-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sun, 23 Feb 2025 01:53:30 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> However, I think we need to either decide that we're going to support
> this as a fully-fledged feature and add documentation and sufficient
> tests, or remove it, since it's not reasonable to have undocumented,
> untested features that people rely on.

Does "this" refer to "use of netrc in HTTP code paths", or "HTTP
walker"?  I am kind of surprised that anybody is still using the
latter, regardless of where the credential is locally stored.

> I will note, as an argument in favour of removal, that we have
> git-credential-netrc helper in contrib that users can enable if
> they want to retain this functionality, and we could even ship it
> by default without much difficulty.

I am fine with the approach.

Thanks.

  parent reply	other threads:[~2025-02-24 16:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 21:34 [Bug] git-http-push authentication fails using netrc-file since v2.46 Peter Georg
2025-02-18 22:53 ` brian m. carlson
2025-02-23  1:53   ` [PATCH 0/1] Fix netrc usage with WebDAV-based HTTP protocol brian m. carlson
2025-02-23  1:53     ` [PATCH 1/1] http: allow using netrc for " brian m. carlson
2025-02-24 16:46     ` Junio C Hamano [this message]
2025-02-24 22:09       ` [PATCH 0/1] Fix netrc usage with " brian m. carlson
2025-02-26 12:38     ` Peter Georg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5ab70ka.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).