From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, Han Jiang <jhcarl0814@gmail.com>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH] config.c: avoid segfault with --fixed-value and valueless config
Date: Mon, 05 Aug 2024 08:45:32 -0700 [thread overview]
Message-ID: <xmqqa5hr55yb.fsf@gitster.g> (raw)
In-Reply-To: <ZrDH3ryOO0wIJIDE@tanuki> (Patrick Steinhardt's message of "Mon, 5 Aug 2024 14:38:54 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> Edge cases like this really make me wonder what the benefit of implicit
> bools is in our config files.
>
> So... why do we have them in the first place? Is there even a single
> good reason?
There isn't any good reason to introduce such a syntax if we were
desigining the configuration file format from scratch. It was added
because originally Linus thought it was a cute syntax, and these
days a lot lot more importantly, it is kept working because you will
break a lot of existing configuration files that were hand tweaked
if you remove the support suddenly.
next prev parent reply other threads:[~2024-08-05 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 17:06 [PATCH] config.c: avoid segfault with --fixed-value and valueless config Taylor Blau
2024-08-05 12:38 ` Patrick Steinhardt
2024-08-05 15:45 ` Junio C Hamano [this message]
2024-08-05 19:46 ` Taylor Blau
2024-08-06 6:17 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5hr55yb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jhcarl0814@gmail.com \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).