From: Junio C Hamano <gitster@pobox.com>
To: David Disseldorp <ddiss@suse.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] notes: do not trigger editor when adding an empty note
Date: Mon, 29 Jul 2024 15:50:17 -0700 [thread overview]
Message-ID: <xmqqa5hzhkye.fsf@gitster.g> (raw)
In-Reply-To: <20240729235333.513eb1d9.ddiss@suse.de> (David Disseldorp's message of "Mon, 29 Jul 2024 23:53:33 +0200")
David Disseldorp <ddiss@suse.de> writes:
> On Mon, 29 Jul 2024 14:37:35 -0700, Junio C Hamano wrote:
> ...
>> I am tempted to squash in
>> ...
>> to make sure that all three options mentioned in the proposed commit
>> log message are tested. It is not too much more effort to do so.
>
> This looks good and works for me - feel free to squash it in.
Will do. Thanks for a quick response.
prev parent reply other threads:[~2024-07-29 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 15:13 [PATCH v2 0/1] notes: fix editor invocation regression David Disseldorp
2024-07-29 15:14 ` [PATCH v2 1/1] notes: do not trigger editor when adding an empty note David Disseldorp
2024-07-29 21:37 ` Junio C Hamano
2024-07-29 21:53 ` David Disseldorp
2024-07-29 22:50 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5hzhkye.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ddiss@suse.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).