From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>,
git@vger.kernel.org,
"AtariDreams via GitGitGadget" <gitgitgadget@gmail.com>,
"Seija Kijin" <doremylover123@gmail.com>,
"Jeff King" <peff@peff.net>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool
Date: Mon, 18 Dec 2023 12:19:49 -0800 [thread overview]
Message-ID: <xmqqa5q7e00q.fsf@gitster.g> (raw)
In-Reply-To: <b7a56625-46d5-4d77-b4bf-5595a6fb2aef@gmail.com> (Phillip Wood's message of "Mon, 18 Dec 2023 16:23:19 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> Thanks for the comprehensive commit message, I agree that we'd be
> better off avoiding adding a fallback. The patch looks good, I did
> wonder if we really need to covert all of these functions for a
> test-balloon but the patch is still pretty small overall.
I do have to wonder, though, if we want to be a bit more careful
than just blindly trusting the platform (i.e. <stdbool.h> might
exist and __STDC_VERSION__ may say C99, but under the hood their
implementation may be buggy and coerce the result of an assignment
of 2 to be different from assigning true).
In any case, this is a good starting place. Let's queue it, see
what happens, and then think about longer-term plans.
Thanks.
next prev parent reply other threads:[~2023-12-18 20:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 17:17 [PATCH] Use ^=1 to toggle between 0 and 1 AtariDreams via GitGitGadget
2023-12-12 17:29 ` Dragan Simic
2023-12-12 20:09 ` Jeff King
2023-12-12 22:30 ` René Scharfe
2023-12-13 8:01 ` Jeff King
2023-12-13 15:17 ` Junio C Hamano
2023-12-14 13:08 ` René Scharfe
2023-12-14 22:05 ` Jeff King
2023-12-15 14:46 ` Phillip Wood
2023-12-15 17:09 ` Junio C Hamano
2023-12-16 10:46 ` René Scharfe
2023-12-18 16:18 ` Phillip Wood
2023-12-16 10:47 ` [PATCH] git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool René Scharfe
2023-12-18 16:23 ` Phillip Wood
2023-12-18 20:19 ` Junio C Hamano [this message]
2023-12-19 13:36 ` René Scharfe
2023-12-21 9:59 ` Jeff King
2023-12-21 9:56 ` [PATCH] Use ^=1 to toggle between 0 and 1 Jeff King
2023-12-21 15:06 ` phillip.wood123
2024-12-18 0:16 ` [PATCH v2] " AreaZR via GitGitGadget
2024-12-18 0:42 ` [PATCH v3] git: use " AreaZR via GitGitGadget
2024-12-18 2:38 ` [PATCH v4] " AreaZR via GitGitGadget
2024-12-18 16:46 ` [PATCH v5] " AreaZR via GitGitGadget
2024-12-18 16:57 ` [PATCH v6] git: use logical-not operator " AreaZR via GitGitGadget
2024-12-19 10:35 ` Junio C Hamano
2024-12-18 15:46 ` [PATCH v3] git: use ^=1 " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5q7e00q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=doremylover123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).