git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: 王常新 <wchangxin824@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] typo: fix the typo 'neeed' into 'needed' in the comment under merge-ort.c
Date: Sat, 21 Oct 2023 10:26:55 -0700	[thread overview]
Message-ID: <xmqqa5sbubs0.fsf@gitster.g> (raw)
In-Reply-To: <DE904895-230C-436E-B7DE-499E6E503DB9@gmail.com> ("王常新"'s message of "Sat, 21 Oct 2023 09:22:36 +0800")

王常新 <wchangxin824@gmail.com> writes:

> Sorry about that, I am not quite familiar with the process. I mean
> I can receive emails at both @qq.com and @gmail.com, but
> <foril@foril.space> in the signed-off-by trailer in the commit
> message doesn’t actually exist.

I cannot tell you which between these two to use, as I do not know
your situation.  When a contributor works on Git and send a patch as
an employee of a company, sometimes the employer wants to see their
name prominently shown in the commit, and that is why we see commits
by folks working on Git for GitHub for example with their
@GitHub.com addresses, even though they may have personal addresses
at @gmail.com.  When a contribution is made as a hobbist (which I
was back when I started contributing to this project), people seem
to prefer using their personal address over using their work
address, so that the name and address recorded in the commit will
stay with them even when they move on.

Whatever name and address you choose, if you are using GGG, you'd
need to update your commits locally, perhaps like so:

  $ git commit --amend --author="Name <a@dd.re.ss>"

(and in the editor you have a chance to make sure your sign-off
matches the authorship).

After that I would suppose that you force push the result to update
your pull-request and /submit again (I am not a user of GGG, so I
may have got the details wrong).

Thanks.

  reply	other threads:[~2023-10-21 17:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 12:24 [PATCH] typo: fix the typo 'neeed' into 'needed' in the comment under merge-ort.c 王常新
2023-10-19 17:05 ` Junio C Hamano
2023-10-20  2:14   ` 王常新
2023-10-20  7:41     ` Bagas Sanjaya
2023-10-20 17:06       ` Junio C Hamano
2023-10-21  8:12         ` Bagas Sanjaya
2023-10-20 16:44     ` Junio C Hamano
2023-10-21  1:22       ` 王常新
2023-10-21 17:26         ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-15 14:08 Wangchangxin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5sbubs0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=wchangxin824@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).