From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] builtin/repack.c: avoid making cruft packs preferred
Date: Tue, 03 Oct 2023 13:20:24 -0700 [thread overview]
Message-ID: <xmqqa5szzcdz.fsf@gitster.g> (raw)
In-Reply-To: <ZRxBlrjyuBmJnx3p@nand.local> (Taylor Blau's message of "Tue, 3 Oct 2023 12:30:14 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Tue, Oct 03, 2023 at 12:27:51PM -0400, Taylor Blau wrote:
>> I've had this sitting in my patch queue for a while now. It's a
>> non-critical performance fix that avoids the repack/MIDX machinery from
>> ever choosing a cruft pack as preferred when writing a MIDX bitmap
>> without a given --preferred-pack.
>>
>> There is no correctness issue here, but choosing a pack with few/no
>> reachable objects means that our pack reuse mechanism will rarely kick
>> in, resulting in performance degradation.
>>
>> builtin/repack.c | 47 ++++++++++++++++++++++++++++++++++++++++-
>> t/t7704-repack-cruft.sh | 39 ++++++++++++++++++++++++++++++++++
>> 2 files changed, 85 insertions(+), 1 deletion(-)
>
> Oops, I should have mentioned that this is meant to be applied on top of
> 'tb/multi-cruft-pack' to reduce the conflict resolution burden. Sorry
> about that.
Sorry, but I do not follow. tb/multi-cruft-pack was merged to
'master' at c0b5d46d (Documentation/gitformat-pack.txt: drop mixed
version section, 2023-08-28) but back then t7704 did not exist. Do
you mean the other topic in-flight from you about max-cruft-size?
next prev parent reply other threads:[~2023-10-03 20:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 16:27 [PATCH] builtin/repack.c: avoid making cruft packs preferred Taylor Blau
2023-10-03 16:30 ` Taylor Blau
2023-10-03 20:20 ` Junio C Hamano [this message]
2023-10-03 21:39 ` Taylor Blau
2023-10-03 20:16 ` Jeff King
2023-10-03 21:52 ` Taylor Blau
2023-10-03 21:54 ` [PATCH v2] " Taylor Blau
2023-10-04 13:13 ` Jeff King
2023-10-05 11:14 ` Patrick Steinhardt
2023-10-05 20:27 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5szzcdz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).