From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4B04CC3DA6F
	for <git@archiver.kernel.org>; Wed, 23 Aug 2023 20:27:01 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236213AbjHWU03 (ORCPT <rfc822;git@archiver.kernel.org>);
        Wed, 23 Aug 2023 16:26:29 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39426 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236502AbjHWU0R (ORCPT <rfc822;git@vger.kernel.org>);
        Wed, 23 Aug 2023 16:26:17 -0400
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF03510DE
        for <git@vger.kernel.org>; Wed, 23 Aug 2023 13:26:13 -0700 (PDT)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id A7C1A195769;
        Wed, 23 Aug 2023 16:26:10 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=8rL+ZwVIddGW2lDwyCluVUGHYnGpYMjnC476DQ
        V5+rQ=; b=KcMbAzLO/XsQmsZWCf7toTY19WiTJUqOVYB0mcQTrdLAWq3v+5ydIV
        bbFyJo84w+N9xs0AloVaDeW+IvbNTXmRa6kppseWTlNeyUjR8gA/XHIBjntoHC89
        E2JKFybspeaqVmGZqJQ1nx9OYdo7kMFEy/ebbSRmruDtvyAo3af9s=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id A020F195768;
        Wed, 23 Aug 2023 16:26:10 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [35.185.212.55])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 17993195767;
        Wed, 23 Aug 2023 16:26:10 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Taylor Blau <me@ttaylorr.com>
Cc:     Alex Henrie <alexhenrie24@gmail.com>, git@vger.kernel.org,
        Jens.Lehmann@web.de
Subject: Re: [PATCH] submodule: deprecate --recurse-submodules=""
References: <20230823032839.731375-1-alexhenrie24@gmail.com>
        <ZOZf4/DYOKqQLjR+@nand.local>
Date:   Wed, 23 Aug 2023 13:26:09 -0700
In-Reply-To: <ZOZf4/DYOKqQLjR+@nand.local> (Taylor Blau's message of "Wed, 23
        Aug 2023 15:37:07 -0400")
Message-ID: <xmqqa5uhfqu6.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 4BE37928-41F3-11EE-A5F7-25B3960A682E-77302942!pb-smtp2.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Taylor Blau <me@ttaylorr.com> writes:

> So here we'd be doing the equivalent of
>
>     *v = RECURSE_SUBMODULES_OFF;
>
> when trying to parse `--recurse-submodules=""`. Should this advice
> instead say "[...] Use --no-recurse-submodules without an argument,
> which does the same thing"?

Sounds right.  So there is nothing to change here, I guess.

If --recurse-submodules="" does something people do not expect to
happen, an warning might be warranted, but I somehow do not think
that is the case here.  If we are not hurting anybody by accepting
that (possibly unusual) form, I do not think we would want to add an
extra warning, either.

Thanks.