From: Junio C Hamano <gitster@pobox.com>
To: "Adam \\\"Sinus\\\" Skawiński" <adam.skawinski@sinpi.net>
Cc: git@vger.kernel.org
Subject: Re: receive.denyCurrentBranch=updateInstead won't update the repo
Date: Tue, 18 Jul 2023 15:28:54 -0700 [thread overview]
Message-ID: <xmqqa5vsg8gp.fsf@gitster.g> (raw)
In-Reply-To: <CAGE71k3tMOtyFVrmGW33RuQ3GufJg8X6ORKCwHQgg6RmXbRCQA@mail.gmail.com> ("Adam \"Sinus\" Skawiński"'s message of "Wed, 19 Jul 2023 00:20:04 +0200")
"Adam \"Sinus\" Skawiński" <adam.skawinski@sinpi.net> writes:
> Correct me if I'm wrong, but I'm looking at receive-pack.c and can't
> grasp one thing.
>
> In receive-pack.c:1452-1453,
>> if (!invoked_hook)
>> retval = push_to_deploy(sha1, &env, worktree->path);
> ... push_to_deploy is reached only if... hook didn't get invoked?
Correct. The hook is responsible for both DECIDING if it wants to
touch/update the working tree, AND ACTUALLY UPDATING the working
tree itself.
And the entire point of the "hook" is that its update does not have
to be just "checkout the given commit's tree", for which using the
default push-to-deply is sufficient. It is for those who want to do
more.
next prev parent reply other threads:[~2023-07-18 22:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 20:26 receive.denyCurrentBranch=updateInstead won't update the repo Adam "Sinus" Skawiński
2023-07-17 20:52 ` Junio C Hamano
2023-07-17 21:09 ` Junio C Hamano
[not found] ` <CAGE71k2bdy2aYy7speu=OOStopgjzVNOPQ_-V-63aCURLibFWw@mail.gmail.com>
2023-07-17 22:26 ` Adam "Sinus" Skawiński
2023-07-18 22:20 ` Adam "Sinus" Skawiński
2023-07-18 22:28 ` Junio C Hamano [this message]
2023-07-18 22:49 ` Adam "Sinus" Skawiński
2023-07-18 23:03 ` Junio C Hamano
2023-07-18 23:29 ` Adam "Sinus" Skawiński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5vsg8gp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adam.skawinski@sinpi.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).