git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] imap-send: some -Wunused-parameter cleanups
Date: Wed, 05 Jul 2023 10:18:18 -0700	[thread overview]
Message-ID: <xmqqa5wa2s6d.fsf@gitster.g> (raw)
In-Reply-To: <20230703063247.GA3524302@coredump.intra.peff.net> (Jeff King's message of "Mon, 3 Jul 2023 02:32:47 -0400")

Jeff King <peff@peff.net> writes:

> Here are a few patches where I opted to clean up code rather than
> marking parameters with UNUSED. Plus a bonus cleanup in patch 3 (though
> I am also OK to drop that one;

> I don't care much about the imap-send
> code, and I'd be just as happy if we deprecated and eventually dropped
> the tool).

Thanks---I too was wondering when we can drop 'imap-send' ;-)

>   [1/3]: imap-send: use server conf argument in setup_curl()
>   [2/3]: imap-send: drop unused parameter from imap_cmd_cb callback
>   [3/3]: imap-send: drop unused fields from imap_cmd_cb
>
>  imap-send.c | 34 +++++++++++++++-------------------
>  1 file changed, 15 insertions(+), 19 deletions(-)
>
> -Peff

      parent reply	other threads:[~2023-07-05 17:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03  6:32 [PATCH 0/3] imap-send: some -Wunused-parameter cleanups Jeff King
2023-07-03  6:33 ` [PATCH 1/3] imap-send: use server conf argument in setup_curl() Jeff King
2023-07-05 17:23   ` Junio C Hamano
2023-07-03  6:34 ` [PATCH 2/3] imap-send: drop unused parameter from imap_cmd_cb callback Jeff King
2023-07-05 17:25   ` Junio C Hamano
2023-07-03  6:34 ` [PATCH 3/3] imap-send: drop unused fields from imap_cmd_cb Jeff King
2023-07-05 17:18 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5wa2s6d.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).