git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] doc: set actual revdate for manpages
Date: Fri, 14 Apr 2023 10:14:04 -0700	[thread overview]
Message-ID: <xmqqa5zas7xf.fsf@gitster.g> (raw)
In-Reply-To: <xmqqildys97o.fsf@gitster.g> (Junio C. Hamano's message of "Fri, 14 Apr 2023 09:46:19 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Formatted output from a repository working tree changes from
> "04/14/2023" to "2023-04-13".  The value change may be intended,...

Forgot to mention another thing.  While it may be a good idea to tie
the datestamp etched in the formatted result to that of the source
material, rather than the date the formatter happened to have been
run, the committer date is more appropriate than the author date for
that purpose, as the former is the date that the change made on the
latter date (which is earlier) has become a part of the whole, from
which the formatted result was produced.

It may not make a big practical difference:

 * For an individual who is trying out the changes just made, the
   committer time and the author time are likely identical.

 * For a release process, what is at the tip of the released branch
   is likely be the release notes and version bump, recorded by the
   releaser, and again the committer time and the author time are
   likely identical.

 * For results of a pull request, the times are likely identical for
   the merge commit.

but from the philosophical standpoint, it does matter.  Using the
committer time would give us one more justification to use one
single timestamp from the commit, when people complain "this manual
page, as opposed to the other one that was changed in the latest
release, has not seen any need to be updated for the past 3 years,
yet the formatted output for these two manual pages carry the same
date".

  reply	other threads:[~2023-04-14 17:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  7:47 [PATCH] doc: set actual revdate for manpages Felipe Contreras
2023-04-14  7:04 ` Jeff King
2023-04-14 12:40   ` Felipe Contreras
2023-04-14 16:46     ` Junio C Hamano
2023-04-14 17:14       ` Junio C Hamano [this message]
2023-04-14 18:40         ` Felipe Contreras
2023-04-14 18:26       ` Felipe Contreras
2023-04-14 21:45       ` Jeff King
2023-04-14 22:06         ` Junio C Hamano
2023-04-14 21:35     ` Jeff King
2023-04-14 15:27   ` Junio C Hamano
2023-04-14 16:20     ` Felipe Contreras
2023-04-14 17:36       ` Junio C Hamano
2023-04-14 18:59         ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5zas7xf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).