From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, "Eric Wong" <e@80x24.org>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] test: cleanups of aggregate-results.sh
Date: Fri, 10 Mar 2023 11:25:47 -0800 [thread overview]
Message-ID: <xmqqa60k5ryc.fsf@gitster.g> (raw)
In-Reply-To: <20230309173032.959968-1-felipe.contreras@gmail.com> (Felipe Contreras's message of "Thu, 9 Mar 2023 11:30:30 -0600")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Basically $title.
>
> Since v1 I'm now passing the directory, instead of the file pattern as
> Ævar suggested.
>
> Also, while at it, let's silence the print of the command.
>
> Felipe Contreras (2):
> test: simplify counts aggregation
> test: don't print aggregate-results command
>
> contrib/subtree/t/Makefile | 4 +---
> t/Makefile | 4 +---
> t/aggregate-results.sh | 2 +-
> 3 files changed, 3 insertions(+), 7 deletions(-)
These two look sensible. Any comments on them by reviewers on the
initial round?
Will queue. Thanks, all.
next prev parent reply other threads:[~2023-03-10 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 17:30 [PATCH v2 0/2] test: cleanups of aggregate-results.sh Felipe Contreras
2023-03-09 17:30 ` [PATCH v2 1/2] test: simplify counts aggregation Felipe Contreras
2023-03-09 17:30 ` [PATCH v2 2/2] test: don't print aggregate-results command Felipe Contreras
2023-03-10 19:25 ` Junio C Hamano [this message]
2023-03-10 21:51 ` [PATCH v2 0/2] test: cleanups of aggregate-results.sh Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa60k5ryc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=e@80x24.org \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).