git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Sergio via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Sergei Krivonos <sergeikrivonos@gmail.com>
Subject: Re: [PATCH 2/2] Add Eclipse project settings files to .gitignore
Date: Thu, 18 Aug 2022 11:17:52 -0700	[thread overview]
Message-ID: <xmqqa681pga7.fsf@gitster.g> (raw)
In-Reply-To: <Yv5wF0DxVe38ygap@tapette.crustytoothpaste.net> (brian m. carlson's message of "Thu, 18 Aug 2022 17:00:07 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> location).  For example, I do this with Vim-related files, and it
> applies to all repos on my system, such that other developers don't have
> to care what editor I use.
>
> However, Eclipse is a popular editor, so it may be that Junio really
> likes this change since it will benefit many people.

I am all for making new contributor's life better, and in this case,
NOT adding editor-specific patterns to OUR .gitignore contributes
better for that goal.  It will be a shame for us to make a move that
will keep our contributors unaware of what they can do with Git, and
in this case, lack of Eclipse specific patterns did trigger Sergio
to notice that these are not ignored, and learn that a better place
to do so is in $HOME/.gitignore, because it will help not only when
the contributor works on Git, but when the same contributor works on
anything using Eclipse.  Adding editor-specific patterns ourselves
robs such a learning opportunity from new contributors.

Thanks.

  reply	other threads:[~2022-08-18 18:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 14:00 [PATCH 0/2] Make rebase.autostash default Sergei Krivonos via GitGitGadget
2022-08-18 14:00 ` [PATCH 1/2] " Sergio via GitGitGadget
2022-08-18 16:55   ` brian m. carlson
2022-08-18 17:25   ` Junio C Hamano
2022-08-18 14:00 ` [PATCH 2/2] Add Eclipse project settings files to .gitignore Sergio via GitGitGadget
2022-08-18 17:00   ` brian m. carlson
2022-08-18 18:17     ` Junio C Hamano [this message]
2022-08-18 19:47       ` rsbecker
2022-08-18 17:31   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa681pga7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sergeikrivonos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).