git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jean-Noël Avila" <jn.avila@free.fr>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Julien Palard" <julien@palard.fr>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	"Sébastien Helleu" <flashcode@flashtux.org>
Subject: Re: [PATCH] Make a colon translatable
Date: Wed, 13 Apr 2022 09:48:27 -0700	[thread overview]
Message-ID: <xmqqa6cp9bfo.fsf@gitster.g> (raw)
In-Reply-To: <10867692-7c2b-1f89-d575-3d9b6e696a24@free.fr> ("Jean-Noël Avila"'s message of "Wed, 13 Apr 2022 15:11:17 +0200")

Jean-Noël Avila <jn.avila@free.fr> writes:

> Just to chime in, I would tend to approve Julien's proposal, but with
> a reworded commit message, which should convey that the segment to 
> translate is not a full sentence.

Thanks.  I think that is probably a sensible thing to do.  The use
of "%s:" (or "%s") is necessitated by the use of status_printf_ln()
in

    status_printf_ln(s, c, "%s", what);

and if we had status_puts() instead, we wouldn't be having this
discussion, as the line would have been

    status_puts(s, c, what);

and it is obvious that "what" (aka "label heading") wants to have
colon after it.

      reply	other threads:[~2022-04-13 16:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  7:02 [PATCH] Make a colon translatable Julien Palard
2022-04-11 19:29 ` Junio C Hamano
2022-04-12  7:30   ` Julien Palard
2022-04-12 16:26     ` Junio C Hamano
2022-04-12  8:03   ` Ævar Arnfjörð Bjarmason
2022-04-12 16:32     ` Junio C Hamano
2022-04-13 13:11       ` Jean-Noël Avila
2022-04-13 16:48         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa6cp9bfo.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=flashcode@flashtux.org \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    --cc=julien@palard.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).