git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jean Abou Samra <jean@abou-samra.fr>
Cc: git@vger.kernel.org
Subject: Re: Git bisect run should check for the existence of the script
Date: Fri, 17 Jul 2020 12:30:59 -0700	[thread overview]
Message-ID: <xmqqa6zydjm4.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <xmqqeepadk8q.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Fri, 17 Jul 2020 12:17:25 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Do you mean a new option must be passed if the end-user expects the
> script to always exist across revisions, or the script is not
> tracked to begin with?  It feels somewhat backwards and the effort
> by the end-user to always type the option is better spent to make
> sure there is no typo on the command line.

I forgot to follow up on this part.

It does not change the conclusion that it needs to be done carefully
if we chose to retroactivelyreserve return code 127 for our own use,
but such a backward incompatible change can easily be worked around
if users relied on the current behaviour that a missing (tracked)
script would mark the revision "bad" without being a fatal error in
"git bisect run".  Instead of

    git bisect run "./tracked-script"

they can just do

    git bisect run "test -f ./tracked-script && ./tracked-script"

and the problem is solved ;-)

      reply	other threads:[~2020-07-17 19:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  8:08 Git bisect run should check for the existence of the script Jean Abou Samra
2020-07-15 14:55 ` Junio C Hamano
2020-07-17 15:09   ` Jean Abou Samra
2020-07-17 19:17     ` Junio C Hamano
2020-07-17 19:30       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa6zydjm4.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jean@abou-samra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).