From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 0/4] deterministic commit timestamps in tests
Date: Fri, 10 Jul 2020 15:02:01 -0700 [thread overview]
Message-ID: <xmqqa707rpuu.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200709203336.GA2748777@coredump.intra.peff.net> (Jeff King's message of "Thu, 9 Jul 2020 16:33:36 -0400")
Jeff King <peff@peff.net> writes:
> Most tests use test_tick or test_commit to get deterministic timestamps
> in commits. Some don't because they don't care about the timestamps. But
> they can still be annoying to debug, since the output changes from run
> to run.
>
> This series sets a default timestamp for those scripts, in a way that
> doesn't interfere with anybody using test_tick. The change is in the
> final commit. The others are preparatory to deal with fallout in the
> test suite. Normally fallout would give me pause about whether this is a
> good idea, but a) there's not much of it and b) I think it helped shake
> out questionable assumptions in those tests.
>
> This a replacement for the patches being discussed in:
>
> https://lore.kernel.org/git/pull.816.git.git.1594149804313.gitgitgadget@gmail.com/
>
> It looks like Junio already picked up one of the fixes as
> jk/t6000-timestamp-fix. The first patch here is identical (so we can
> either drop that branch, or drop the first patch from this series and
> apply on top).
>
> [1/4]: t6000: use test_tick consistently
> [2/4]: t9700: loosen ident timezone regex
> [3/4]: t5539: make timestamp requirements more explicit
> [4/4]: test-lib: set deterministic default author/committer date
>
> t/t5539-fetch-http-shallow.sh | 4 +++-
> t/t6000-rev-list-misc.sh | 7 +++++--
> t/t9700/test.pl | 6 +++---
> t/test-lib.sh | 3 +++
> 4 files changed, 14 insertions(+), 6 deletions(-)
>
> -Peff
I have this queued on top for today's integration run. The last
step is something worth doing in the longer term, but certainly not
for the upcoming release ;-).
-- >8 --
Subject: [PATCH] BANDAID: t9100.17 & t9100.18
---
t/t9100-git-svn-basic.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh
index 2c309a57d9..33ea813585 100755
--- a/t/t9100-git-svn-basic.sh
+++ b/t/t9100-git-svn-basic.sh
@@ -8,6 +8,8 @@ GIT_SVN_LC_ALL=${LC_ALL:-$LANG}
. ./lib-git-svn.sh
+unset GIT_AUTHOR_DATE GIT_COMMITTER_DATE
+
case "$GIT_SVN_LC_ALL" in
*.UTF-8)
test_set_prereq UTF8
--
2.28.0-rc0
next prev parent reply other threads:[~2020-07-10 22:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 20:33 [PATCH 0/4] deterministic commit timestamps in tests Jeff King
2020-07-09 20:34 ` [PATCH 1/4] t6000: use test_tick consistently Jeff King
2020-07-09 20:35 ` [PATCH 2/4] t9700: loosen ident timezone regex Jeff King
2020-07-09 20:39 ` [PATCH 3/4] t5539: make timestamp requirements more explicit Jeff King
2020-07-09 20:42 ` [PATCH 4/4] test-lib: set deterministic default author/committer date Jeff King
2020-07-10 22:02 ` Junio C Hamano [this message]
2020-07-14 12:31 ` [PATCH 0/4] deterministic commit timestamps in tests Jeff King
2020-07-14 12:33 ` Jeff King
2020-07-14 21:47 ` Eric Wong
2020-07-15 7:42 ` Jeff King
2020-07-15 14:50 ` Junio C Hamano
2020-07-15 15:04 ` Junio C Hamano
2020-07-16 10:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa707rpuu.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).