From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Denton Liu <liu.denton@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] checkout: teach --worktree
Date: Sun, 14 Jun 2020 14:37:07 -0700 [thread overview]
Message-ID: <xmqqa715xrb0.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cQ_G+N=mYqO+=7UaAYft27MhZ2_3v8=QzYpDn5hQySp+A@mail.gmail.com> (Eric Sunshine's message of "Sat, 13 Jun 2020 22:51:47 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> + When writing contents, only modify files in the worktree. Do not
>> + modify the index. This option is essentially a no-op when used
>> + without a `<tree-ish>`.
>
> Why a no-op rather than actually diagnosing that --worktree makes no
> sense in that case and erroring out?
Should it be a no-op? If checking paths out of the index, with or
without the new --worktree option, the files in the working tree
will be affected and the contents in the index won't change.
next prev parent reply other threads:[~2020-06-14 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 14:25 [PATCH] checkout: teach --worktree Denton Liu
2020-06-14 2:51 ` Eric Sunshine
2020-06-14 7:44 ` Denton Liu
2020-06-14 8:02 ` Denton Liu
2020-06-14 21:37 ` Junio C Hamano [this message]
2020-06-14 8:49 ` [PATCH v2] " Denton Liu
2020-06-16 16:01 ` Phillip Wood
2020-06-23 15:55 ` Denton Liu
2020-06-24 10:20 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa715xrb0.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).