From: Junio C Hamano <gitster@pobox.com>
To: Ismael Luceno <ismael@iodev.co.uk>
Cc: git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Pat Thoyts <patthoyts@users.sourceforge.net>
Subject: Re: [PATCH v2] git-gui: Handle Ctrl + BS/Del in the commit msg
Date: Thu, 21 Feb 2019 12:47:31 -0800 [thread overview]
Message-ID: <xmqqa7iouavw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190221093059.GA6594@kiki> (Ismael Luceno's message of "Thu, 21 Feb 2019 10:31:00 +0100")
Ismael Luceno <ismael@iodev.co.uk> writes:
>> .... I am not sure if going
>> back by one character from where the current insertion cursor is and
>> further go back to the wordstart would give the beginning of the
>> word to the left of the cursor, though.
>
> ...
> Current implementation doesn't behave correctly when there's multiple
> spaces:
In short, I wondered if it is correct, and you say it is not correct.
I would be surprised if git-gui were the only program that
implemented an editor-like feature using tcl/tk, and none of the
other editor implementations using tcl/tk had such an industry
standard "delete previous word". Perhaps you can see if there
is already a correct implementation of the feature this patch can
borrow from?
>> A larger issue is that we haven't heard from Pat, who has been
>> helping git-gui.sh maintenance, for quite a while, so we'd need to
>> find a volunteer to act as a replacement maintainer. If you are
>> willing to, that would be great ;-)
>
> Sure.
next prev parent reply other threads:[~2019-02-21 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 3:10 [PATCH v2] git-gui: Handle Ctrl + BS/Del in the commit msg Ismael Luceno
2019-02-20 20:05 ` Junio C Hamano
2019-02-21 9:31 ` Ismael Luceno
2019-02-21 20:47 ` Junio C Hamano [this message]
2019-03-04 14:09 ` Ismael Luceno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7iouavw.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ismael@iodev.co.uk \
--cc=patthoyts@users.sourceforge.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).