From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: "Duy Nguyen" <pclouds@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH] helper/test-ref-store: fix "new-sha1" vs "old-sha1" typo
Date: Thu, 17 Jan 2019 10:53:59 -0800 [thread overview]
Message-ID: <xmqqa7jznmig.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAP8UFD2vLhn1_hUefKfsE8+3SDZk6qzf8eS-DUoZLhf41QiyAg@mail.gmail.com> (Christian Couder's message of "Wed, 16 Jan 2019 12:13:10 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> On Mon, Jan 7, 2019 at 1:53 PM Duy Nguyen <pclouds@gmail.com> wrote:
>>
>> On Sun, Jan 6, 2019 at 10:46 PM Christian Couder
>> <christian.couder@gmail.com> wrote:
>> >
>> > It looks like it is a copy-paste error made in 80f2a6097c
>> > (t/helper: add test-ref-store to test ref-store functions,
>> > 2017-03-26) to pass "old-sha1" instead of "new-sha1" to
>> > notnull() when we get the new sha1 argument from
>> > const char **argv.
>>
>> Ack. Definitely copy-paste error.
>
> Thanks for confirming.
>
> Junio, it looks like the patch has fallen through the cracks.
Indeed. I did notice two smallish cleanups from you but did not
spot this one.
Will take a look and queue.
Thanks.
>
> Or maybe I should rework the commit message?
prev parent reply other threads:[~2019-01-17 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 15:46 [PATCH] helper/test-ref-store: fix "new-sha1" vs "old-sha1" typo Christian Couder
2019-01-07 12:53 ` Duy Nguyen
2019-01-16 11:13 ` Christian Couder
2019-01-17 18:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7jznmig.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).