From: Junio C Hamano <gitster@pobox.com>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: John Passaro <john.a.passaro@gmail.com>,
git@vger.kernel.org, alex.crezoff@gmail.com, peff@peff.net
Subject: Re: [PATCH 0/4] Expose gpgsig in pretty-print
Date: Sat, 15 Dec 2018 09:26:44 +0900 [thread overview]
Message-ID: <xmqqa7l7d48r.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <1544760713.970.1.camel@gentoo.org> ("Michał Górny"'s message of "Fri, 14 Dec 2018 05:11:53 +0100")
Michał Górny <mgorny@gentoo.org> writes:
> Just a suggestion: since the raw signature is not very useful without
> the commit data to check it against, and the commit data is non-trivial
> to construct (requires mangling raw data anyway), maybe you could either
> add another placeholder to get the data for signature verification, or
> (alternatively or simultaneously) add a placeholder that prints both
> data and signature in the OpenPGP message format (i.e. something you can
> pass straight to 'gpg --verify').
Yeah, the last would be the most usable; anything short of that, I
have to suspect that going from "cat-file commit", rather than using
this new %Gsomething placeholder, would be more practical.
prev parent reply other threads:[~2018-12-15 0:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 21:22 [PATCH 0/4] Expose gpgsig in pretty-print John Passaro
2018-12-13 21:22 ` [PATCH 1/4] pretty: expose raw commit signature John Passaro
2018-12-13 21:22 ` [PATCH 2/4] t/t7510-signed-commit.sh: test new placeholders John Passaro
2018-12-13 21:22 ` [PATCH 3/4] doc, tests: pretty behavior when gpg missing John Passaro
2018-12-13 21:22 ` [PATCH 4/4] docs/pretty-formats: add explanation + copy edits John Passaro
2018-12-14 4:11 ` [PATCH 0/4] Expose gpgsig in pretty-print Michał Górny
2018-12-14 16:07 ` John Passaro
2018-12-14 16:48 ` Michał Górny
2018-12-14 23:10 ` John Passaro
2018-12-14 23:13 ` John Passaro
2018-12-17 20:24 ` Jeff King
2018-12-19 5:59 ` John Passaro
2018-12-21 13:52 ` Michał Górny
2018-12-15 0:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7l7d48r.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=alex.crezoff@gmail.com \
--cc=git@vger.kernel.org \
--cc=john.a.passaro@gmail.com \
--cc=mgorny@gentoo.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).