From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>,
Git Mailing list <git@vger.kernel.org>
Subject: Re: "git grep" and "working tree" vs "working directory"
Date: Fri, 25 May 2018 09:55:52 +0900 [thread overview]
Message-ID: <xmqqa7sor1t3.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAGZ79kavmH5KVS2Byc5+Hg3dOvVwGD11KZ3yzZTLwp8Ok9ZDTg@mail.gmail.com> (Stefan Beller's message of "Thu, 24 May 2018 13:50:56 -0700")
Stefan Beller <sbeller@google.com> writes:
> There are 2 dimensions to it:
> * (where you are)
> if you run git-grep from a sub directory of the repository, then the
> "sub-working-tree"
> will be searched.
s/the repository/the top level directory of the working tree/, perhaps?
>> also, at the bottom of that section, one reads:
>>
>> <pathspec>...
>> If given, limit the search to paths matching at least one
>> pattern. Both leading paths match and glob(7) patterns are supported.
>>
>> For more details about the <pathspec> syntax, see the pathspec
>> entry in gitglossary(7).
>>
>> but, again, what if <pathspec> is *not* given? then what?
>
> Assume "$pwd/."
This is not technically wrong per-se, but I do not think there is
any reason to encourage it over just a simple "." dot.
>> finally, the first example has the same problem:
>>
>> git grep 'time_t' -- '*.[ch]'
>> Looks for time_t in all tracked .c and .h files in the
>> working directory and its subdirectories.
>>
>> in "the working directory"?
>>
>> what is the proper terminology to be used here?
>
> the working directory sounds right, not sure which aspect you want to be
> exposed more clearly.
"The part of the working tree below and including your current
working directory", if you really want to be pedantic ;-).
But almost all the examples that show how to work _with_ Git
inspecting and manipulating tracked contents assume that your
current working directory _is_ inside a working tree of the
repository you are working on, so the above is equivalent to "The
current working directory" should be clear enough for most readers,
I would think.
next prev parent reply other threads:[~2018-05-25 0:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 18:50 "git grep" and "working tree" vs "working directory" Robert P. J. Day
2018-05-24 20:50 ` Stefan Beller
2018-05-25 0:55 ` Junio C Hamano [this message]
2018-05-25 10:56 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7sor1t3.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).