From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C58B620446 for ; Tue, 17 Oct 2017 08:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934413AbdJQIVG (ORCPT ); Tue, 17 Oct 2017 04:21:06 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:61873 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934291AbdJQIVD (ORCPT ); Tue, 17 Oct 2017 04:21:03 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 8D873BAB86; Tue, 17 Oct 2017 04:21:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=jmSWCdvQOrkWKMn9qzc85EWsXV4=; b=Bj6XSw k9yXUuFln3DJ4CvVRT3/SZRVFvI4E/19d4ALhgVmzeCBHyjR4ZSOxEytVpSI2nqS Pdyc3gdSpIDMsXf6jQQ7mdwlAJSiCsO1nNN4eMXnxgPqqF44XQ0eCS8x1Aar3PqW ufUADD9ZsT9g1Nh8zulSyqyVJ+yyf8ABWvwFk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=OKlMbzQ2pz+Y8Iokd3mOkxP92a0ILJ5j tk38wsWNK4k4RsIOYfsNrmtMQ7wO8tvxjipOSFG3Kph9VwJmlmWpn3tY0TV3L+R1 tQrx9y3J5bU17bV/VfKcMnQc5z2HBeTIJBBbwmihBEAY2o2ULY6x9qAtDfd22ZUC MANHJOWvvx0= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 848D7BAB85; Tue, 17 Oct 2017 04:21:02 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D16BABAB83; Tue, 17 Oct 2017 04:21:01 -0400 (EDT) From: Junio C Hamano To: Jonathan Nieder Cc: Jeff King , Marko Kungla , git@vger.kernel.org Subject: Re: [PATCH 0/3] Re: [PATCH] check-ref-format: require a repository for --branch References: <20170817102217.3yw7uxnkupdy3lh5@sigill.intra.peff.net> <20171016224512.6fhtce5anmff577b@sigill.intra.peff.net> <20171017024203.6hqzy2paed6fyvym@sigill.intra.peff.net> <20171017070619.bdgvujmbw4uxvwle@aiede.mtv.corp.google.com> <20171017071758.ltzustqxcbp3yet7@aiede.mtv.corp.google.com> Date: Tue, 17 Oct 2017 17:21:00 +0900 In-Reply-To: <20171017071758.ltzustqxcbp3yet7@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Tue, 17 Oct 2017 00:17:58 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 1C9C2DC8-B314-11E7-B0B7-575F0C78B957-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jonathan Nieder writes: > Junio C Hamano wrote: >> Jonathan Nieder writes: > >>> Handles the nongit case in strbuf_check_branch_ref instead of >>> introducing a new check_branch_ref_format helper. >> >> I view that as a regression, actually. Don't we want a function >> that does not require a strbuf when asking a simple question: "I >> have a string, and I want to see if that is a valid name"? > > *shrug* I found the change easier to read, and it also sidesteps the > which-header question. It also ensures that other > strbuf_check_branch_ref callers are safe without having to audit them. Please ignore the above, which was merely an impression _without_ and before having received any patch to comment on ;-) Quite frankly, this is a Meh topic that won't have to hit even 'next' before the final. The color.ui=always thing has a lot more urgency, and this was merely what I did while waiting for others to react to that topic.