Re: [PATCH v3 15/28] fetch: add --update-shallow to get refs that require updating .git/shallow

[Junio C Hamano <gitster@pobox.com>]

Duy Nguyen <pclouds@gmail.com> writes:

> On Wed, Nov 27, 2013 at 8:53 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Sun, Nov 24, 2013 at 10:55 PM, Nguyễn Thái Ngọc Duy
>> <pclouds@gmail.com> wrote:
>>> diff --git a/t/t5536-fetch-shallow.sh b/t/t5536-fetch-shallow.sh
>>> index e011ead..95b6313 100755
>>> --- a/t/t5536-fetch-shallow.sh
>>> +++ b/t/t5536-fetch-shallow.sh
>>> @@ -141,4 +141,26 @@ EOF
>>>         )
>>>  '
>>>
>>> +test_expect_success 'fetch --update-shallow' '
>>> +       (
>>> +       cd notshallow &&
>>> +       git fetch --update-shallow ../shallow/.git refs/heads/*:refs/remotes/shallow/* &&
>>> +       git fsck &&
>>> +       git for-each-ref --format="%(refname)" |sort >actual.refs &&
>>
>> Exit status of git-for-each-ref could be lost down the pipe.
>
> I think it's ok. If for-each-ref is broken or something the final
> output in actual.refs will be different anyway.

You can tell for-each-ref to sort its output in a way you specify,
no?