Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Pablo Sabater" <pabloosabaterr@gmail.com>
Cc: "Caspar Duregger" <caspar.duregger@gmail.com>,
	 <git@vger.kernel.org>, <krka@spotify.com>,
	 <karthik.188@gmail.com>, <chandrapratap3519@gmail.com>
Subject: Re: [PATCH] graph: do not indent visual roots with columns to their right
Date: Wed, 04 Nov 2026 10:00:17 -0800	[thread overview]
Message-ID: <xmqqbj8432a6.fsf@gitster.g> (raw)
In-Reply-To: <DMLZ0DCQXG54.2FD3JQXSJCWPD@gmail.com> (Pablo Sabater's message of "Tue, 03 Nov 2026 23:39:22 +0000")

"Pablo Sabater" <pabloosabaterr@gmail.com> writes:

> On Tue Nov 3, 2026 at 11:11 PM WET, Caspar Duregger wrote:
>> Since a34c00d96 (graph: indent visual root in graph, 2026-07-14), a
>> visual root that has a child is drawn indented, connected to its child
>> by an extra GRAPH_PRE_ROOT line.  When there are columns to the right
>> of the root, this breaks the graph:
>
> The patch looks good to me!
>
> Regards,
> Pablo

Thanks, both.  Queued.


      reply	other threads:[~2026-11-04 18:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 19:00 log --graph draws an orphaned branch with parents herr.kaste
2026-11-03 19:25 ` herr.kaste
2026-11-03 21:27   ` Pablo Sabater
2026-11-03 21:29     ` Pablo Sabater
2026-11-03 21:51       ` herr.kaste
2026-11-03 22:40         ` Pablo Sabater
2026-11-03 23:11 ` [PATCH] graph: do not indent visual roots with columns to their right Caspar Duregger
2026-11-03 23:39   ` Pablo Sabater
2026-11-04 18:00     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbj8432a6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=caspar.duregger@gmail.com \
    --cc=chandrapratap3519@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=krka@spotify.com \
    --cc=pabloosabaterr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox