From: Junio C Hamano <gitster@pobox.com>
To: "Michael Montalbo via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Michael Montalbo <mmontalbo@gmail.com>
Subject: Re: [PATCH v2 0/4] line-log: route -L output through the standard diff pipeline
Date: Tue, 31 Mar 2026 14:49:34 -0700 [thread overview]
Message-ID: <xmqqbjg3y8i9.fsf@gitster.g> (raw)
In-Reply-To: <pull.2065.v2.git.1773714095.gitgitgadget@gmail.com> (Michael Montalbo via GitGitGadget's message of "Tue, 17 Mar 2026 02:21:31 +0000")
"Michael Montalbo via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Known limitations not addressed in this series:
>
> * line_log_print() still calls show_log() and diff_flush() directly,
> bypassing log_tree_diff_flush(). The early return in log_tree_commit()
> (and its associated NEEDSWORK about no_free not being restored) is
> pre-existing. Restructuring -L to flow through log_tree_diff_flush() is a
> larger change that would affect separator and header logic; it is left
> for a follow-up.
>
> * Non-patch diff formats (--raw, --numstat, --stat, etc.) remain
> unimplemented for -L.
>
> cc: "Kristoffer Haugsbakk" kristofferhaugsbakk@fastmail.com
>
> Changes since v1:
>
> * Patch 4/4: fix documentation formatting: use line continuation
> instead of indentation (Kristoffer Haugsbakk)
The central part of the series (i.e., patch #2) looked quite
sensible. I haven't read the tests very carefully, though.
I was hoping that we will see another set of eyes or two to help
review this series, but nothing has happend in the past few weeks,
so let's mark the topic for 'next'.
Thanks.
prev parent reply other threads:[~2026-03-31 21:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 1:02 [PATCH 0/4] line-log: route -L output through the standard diff pipeline Michael Montalbo via GitGitGadget
2026-03-07 1:02 ` [PATCH 1/4] line-log: fix crash when combined with pickaxe options Michael Montalbo via GitGitGadget
2026-03-07 1:02 ` [PATCH 2/4] line-log: route -L output through the standard diff pipeline Michael Montalbo via GitGitGadget
2026-03-07 1:02 ` [PATCH 3/4] t4211: add tests for -L with standard diff options Michael Montalbo via GitGitGadget
2026-03-07 1:02 ` [PATCH 4/4] doc: note that -L supports patch formatting and pickaxe options Michael Montalbo via GitGitGadget
2026-03-11 8:41 ` Kristoffer Haugsbakk
2026-03-11 17:35 ` Michael Montalbo
2026-03-07 1:28 ` [PATCH 0/4] line-log: route -L output through the standard diff pipeline Junio C Hamano
2026-03-07 1:37 ` Michael Montalbo
2026-03-07 2:05 ` Junio C Hamano
2026-03-07 2:10 ` Michael Montalbo
2026-03-17 2:21 ` [PATCH v2 " Michael Montalbo via GitGitGadget
2026-03-17 2:21 ` [PATCH v2 1/4] line-log: fix crash when combined with pickaxe options Michael Montalbo via GitGitGadget
2026-03-17 2:21 ` [PATCH v2 2/4] line-log: route -L output through the standard diff pipeline Michael Montalbo via GitGitGadget
2026-03-17 20:52 ` Junio C Hamano
2026-03-17 2:21 ` [PATCH v2 3/4] t4211: add tests for -L with standard diff options Michael Montalbo via GitGitGadget
2026-03-17 2:21 ` [PATCH v2 4/4] doc: note that -L supports patch formatting and pickaxe options Michael Montalbo via GitGitGadget
2026-03-31 21:49 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbjg3y8i9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mmontalbo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox