From: Junio C Hamano <gitster@pobox.com>
To: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Cc: git@vger.kernel.org, pushkarkumarsingh1970@gmail.com
Subject: Re: [PATCH] doc: MyFirstContribution: fix missing dependencies and clarify build steps
Date: Mon, 12 Jan 2026 10:51:29 -0800 [thread overview]
Message-ID: <xmqqbjiymzpq.fsf@gitster.g> (raw)
In-Reply-To: <20260112161538.351527-1-shreyanshpaliwalcmsmn@gmail.com> (Shreyansh Paliwal's message of "Mon, 12 Jan 2026 21:41:09 +0530")
Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
>> I personally find that stopping at asciidoc and let the user deal
>> with their platform convention to get asciidoc working, like the
>> current documentation does, draws the line better than the above
>> updated text.
> ...
> Please let me know what would be the appropriate approach with this.
Again, I personally find that stopping at asciidoc and letting the
user deal with their platform convention to get asciidoc working,
like the current documentation does, draws the line better.
If we are not mentioning to check INSTALL elsewhere in the
instruction, we probably should, and the place where we mention what
software you need to install (like compilers, make, etc.) would be
more appropriate, than a note about building documentation.
Thanks.
next prev parent reply other threads:[~2026-01-12 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 17:40 [PATCH] Documentation/MyFirstContribution: add missing dependencies and clarify build steps Shreyansh Paliwal
2026-01-12 9:40 ` [PATCH] doc: MyFirstContribution: fix " Shreyansh Paliwal
2026-01-12 12:55 ` Pushkar Singh
2026-01-12 16:05 ` Shreyansh Paliwal
2026-01-12 14:34 ` Junio C Hamano
2026-01-12 16:11 ` Shreyansh Paliwal
2026-01-12 18:51 ` Junio C Hamano [this message]
2026-01-12 19:10 ` Shreyansh Paliwal
2026-01-12 19:53 ` [PATCH v2] " Shreyansh Paliwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbjiymzpq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pushkarkumarsingh1970@gmail.com \
--cc=shreyanshpaliwalcmsmn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox