git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Okhuomon Ajayi <okhuomonajayi54@gmail.com>,  git@vger.kernel.org
Subject: Re: [PATCH] [PATCH] [Outreachy] builtin/patch-id.c: clarify SHA1 usage for patch IDs
Date: Wed, 15 Oct 2025 06:37:01 -0700	[thread overview]
Message-ID: <xmqqbjm8waki.fsf@gitster.g> (raw)
In-Reply-To: <aO7Tgj4OJVLhFASW@fruit.crustytoothpaste.net> (brian m. carlson's message of "Tue, 14 Oct 2025 22:49:38 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> Given that context, I think allowing the specification of an algorithm
> would allow people to say, "Yes, I am in a SHA-256 repository, but I
> want SHA-1," or vice versa, which would work with your use case better.

That is sensible.

In short, the automatic choice is to use the repository's hash
inside a repository, or use the then-default algorithm (which comes
from the preimage of the patch we discussed in this thread) outside
a repository.  We want a "Use this hash algorithm, ignoring the
automatic choice" command line option that overrides it.

If we were to do configuration variables, we may need two.  One to
replace only the fallback part (i.e. outside a repository, instead
of using whatever then-current algorithm, use this one), and the
other to act as if the above command line option is always given.

But as always, starting with only a command line option would be a
prudent way forward.

Thanks.

  parent reply	other threads:[~2025-10-15 13:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 17:46 [PATCH] [PATCH] [Outreachy] builtin/patch-id.c: clarify SHA1 usage for patch IDs Okhuomon Ajayi
2025-10-14  3:00 ` Junio C Hamano
2025-10-14  8:04   ` Okhuomon Ajayi
2025-10-14 21:18 ` brian m. carlson
2025-10-14 22:29   ` Junio C Hamano
2025-10-14 22:49     ` brian m. carlson
2025-10-14 23:27       ` Okhuomon Ajayi
2025-10-15 13:37       ` Junio C Hamano [this message]
2025-10-15 13:59         ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbjm8waki.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=okhuomonajayi54@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).