git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>,
	 Phillip Wood <phillip.wood@dunelm.org.uk>,
	 git@vger.kernel.org,  Derrick Stolee <stolee@gmail.com>,
	 "D . Ben Knoble" <ben.knoble@gmail.com>
Subject: Re: [PATCH v2 0/4] midx repack: fix overflow on 32 bit systems
Date: Tue, 27 May 2025 08:42:34 -0700	[thread overview]
Message-ID: <xmqqbjreqcut.fsf@gitster.g> (raw)
In-Reply-To: <7b6ebd22-78d9-486a-8be8-3da475015a8e@gmail.com> (Phillip Wood's message of "Tue, 27 May 2025 09:26:24 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 23/05/2025 01:36, Taylor Blau wrote:
>> On Thu, May 22, 2025 at 04:55:19PM +0100, Phillip Wood wrote:
>>> Phillip Wood (4):
>>>    midx repack: avoid integer overflow on 32 bit systems
>>>    midx repack: avoid potential integer overflow on 64 bit systems
>>>    midx: avoid negative array index
>>>    midx docs: clarify tie breaking
>>>
>>>   Documentation/git-multi-pack-index.adoc | 11 +++++++----
>>>   git-compat-util.h                       | 16 ++++++++++++++++
>>>   midx-write.c                            | 22 ++++++++++++++++------
>>>   3 files changed, 39 insertions(+), 10 deletions(-)
>>>
>>> Range-diff against v1:
>> Thanks, the range-diff and patches look great to me.
>
> That's great, thank you for you comments and suggestions especially
> with regard to large repositories.

Thanks, both.  Let's mark the topic for next.



      reply	other threads:[~2025-05-27 15:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 15:04 [PATCH 0/4] midx repack: fix overflow on 32 bit systems Phillip Wood
2025-05-20 15:04 ` [PATCH 1/4] midx repack: avoid integer " Phillip Wood
2025-05-20 17:54   ` Taylor Blau
2025-05-21 15:19     ` Phillip Wood
2025-05-23  0:34       ` Taylor Blau
2025-05-21 13:10   ` D. Ben Knoble
2025-05-21 15:01     ` Junio C Hamano
2025-05-21 15:20     ` Phillip Wood
2025-05-20 15:04 ` [PATCH 2/4] midx repack: avoid potential integer overflow on 64 " Phillip Wood
2025-05-20 17:59   ` Taylor Blau
2025-05-21 15:20     ` Phillip Wood
2025-05-20 15:04 ` [PATCH 3/4] midx: avoid negative array index Phillip Wood
2025-05-20 17:58   ` Taylor Blau
2025-05-20 15:04 ` [PATCH 4/4] midx docs: clarify tie breaking Phillip Wood
2025-05-20 18:07   ` Taylor Blau
2025-05-21 15:20     ` Phillip Wood
2025-05-21 13:14   ` D. Ben Knoble
2025-05-22 15:55 ` [PATCH v2 0/4] midx repack: fix overflow on 32 bit systems Phillip Wood
2025-05-22 15:55   ` [PATCH v2 1/4] midx repack: avoid integer " Phillip Wood
2025-05-22 15:55   ` [PATCH v2 2/4] midx repack: avoid potential integer overflow on 64 " Phillip Wood
2025-05-22 15:55   ` [PATCH v2 3/4] midx: avoid negative array index Phillip Wood
2025-05-22 15:55   ` [PATCH v2 4/4] midx docs: clarify tie breaking Phillip Wood
2025-05-23  0:36   ` [PATCH v2 0/4] midx repack: fix overflow on 32 bit systems Taylor Blau
2025-05-27  8:26     ` Phillip Wood
2025-05-27 15:42       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbjreqcut.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).