From: Junio C Hamano <gitster@pobox.com>
To: Justin Tobler <jltobler@gmail.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,
git@vger.kernel.org, stolee@gmail.com
Subject: Re: [PATCH] t: remove unexpected SANITIZE_LEAK variables
Date: Tue, 20 May 2025 15:09:50 -0700 [thread overview]
Message-ID: <xmqqbjrngci9.fsf@gitster.g> (raw)
In-Reply-To: <dw57mhszlyk3s4rvitdthpbaoiicjnnraq24e6uxaeu2kze26d@xpiouvxmhowr> (Justin Tobler's message of "Tue, 20 May 2025 16:16:02 -0500")
Justin Tobler <jltobler@gmail.com> writes:
> On 25/05/20 04:40PM, Karthik Nayak wrote:
>> As of 1fc7ddf35b (test-lib: unconditionally enable leak checking,
>> 2024-11-20), both the `GIT_TEST_PASSING_SANITIZE_LEAK` and
>> `TEST_PASSES_SANITIZE_LEAK` variables no longer have any meaning, the
>> leak checks are enabled by default. However, some newly added tests
>> include them by mistake. Let's clean this up.
>
> Indeed, both `GIT_TEST_PASSING_SANITIZE_LEAK` and
> `TEST_PASSES_SANITIZE_LEAK` appear not have any purpose anymore.
> Removing all remaining instances where they appear makes sense and from
> a quick search it looks like this patch got them all. So this looks good
> to me.
Thanks, both.
next prev parent reply other threads:[~2025-05-20 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 14:40 [PATCH] t: remove unexpected SANITIZE_LEAK variables Karthik Nayak
2025-05-20 21:16 ` Justin Tobler
2025-05-20 22:09 ` Junio C Hamano [this message]
2025-05-22 6:06 ` Jeff King
2025-05-22 6:09 ` Jeff King
2025-05-22 9:06 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbjrngci9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).