From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Patrick Steinhardt <ps@pks.im>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: v2.47.0-rc1 test failure on cygwin
Date: Fri, 04 Oct 2024 09:09:01 -0700 [thread overview]
Message-ID: <xmqqbjzzg89u.fsf@gitster.g> (raw)
In-Reply-To: <f29241a7-aadd-e824-97f3-a95ac6619951@gmx.de> (Johannes Schindelin's message of "Fri, 4 Oct 2024 13:11:15 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> But unfortunately this still caused permission errors when the new path
>> was held open by another process.
>
> Yes, this will _always_ be a problem, I think. The
> `FILE_RENAME_POSIX_SEMANTICS` as per its documentation should help, but if
> it does not in your tests it might actually not quite work as advertised
> (wouldn't be the first time I encounter such an issue).
>
> I tried to read through the code (it's a lot!) to figure out whether there
> is potentially any situation when the `tables.list` file is opened but not
> closed immediately, but couldn't find any. Do you know off-hand of any
> such scenario?
>
>> I think for now I'd still lean into the direction of adding the !WINDOWS
>> prerequisite to the test and increasing timeouts such that I can
>> continue to investigate without time pressure.
>
> Let me bang my head against this problem for a little while longer. You
> might be right, though, that this is a thing we cannot fix in time for
> v2.47.0, which would be sad.
If you folks think it would help stabilizing the tentative fix, I am
open to the idea of delaying the 2.47 by a few days. Currently the
2.47-final is scheduled on the 7th (Monday), but we can do 2.47-rc2
on that day instead, and move the final to 10th (Thu) or 11th (Fri)
[*].
Thanks, all, for working together.
[Footnote]
* All dates are US/Pacific, 10:00 am
next prev parent reply other threads:[~2024-10-04 16:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 1:02 v2.47.0-rc1 test failure on cygwin Ramsay Jones
2024-10-04 3:59 ` Patrick Steinhardt
2024-10-04 6:13 ` Patrick Steinhardt
2024-10-04 9:13 ` Johannes Schindelin
2024-10-04 10:09 ` Patrick Steinhardt
2024-10-04 11:11 ` Johannes Schindelin
2024-10-04 11:32 ` Patrick Steinhardt
2024-10-04 16:09 ` Junio C Hamano [this message]
2024-10-04 17:14 ` Patrick Steinhardt
2024-10-04 17:54 ` Junio C Hamano
2024-10-04 12:16 ` [PATCH] t0610: work around flaky test with concurrent writers Patrick Steinhardt
2024-10-04 14:47 ` Ramsay Jones
2024-10-04 15:26 ` Patrick Steinhardt
2024-10-04 16:32 ` Junio C Hamano
2024-10-04 16:22 ` Junio C Hamano
2024-10-04 15:32 ` [PATCH v2] " Patrick Steinhardt
2024-10-04 16:32 ` Ramsay Jones
2024-10-04 16:35 ` Junio C Hamano
2024-10-04 22:41 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbjzzg89u.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).