From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Chandra Pratap <chandrapratap3519@gmail.com>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [GSoC][PATCH v2 3/4] t: move tests from reftable/record_test.c to the new unit test
Date: Wed, 29 May 2024 15:38:17 -0700 [thread overview]
Message-ID: <xmqqbk4otfae.fsf@gitster.g> (raw)
In-Reply-To: <Zlb1m5cwhW_R5EzP@tanuki> (Patrick Steinhardt's message of "Wed, 29 May 2024 11:30:03 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> + strbuf_release(&a);
>> + strbuf_release(&b);
>> +}
>
> Oh, so this test was even duplicated. It may make sense to point out
> details like this in the commit message to prepare the reader. But
> that's probably not worth a reroll.
Probably. But if you are sending out another round anyway, then it
is a good opportunity to update the proposed log message.
;-)
next prev parent reply other threads:[~2024-05-29 22:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <--in-reply-to=20240528113856.8348-1-chandrapratap3519@gmail.com>
2024-05-29 6:55 ` [GSoC][PATCH v2 0/4] t: port reftable/basics_test.c to the unit testing Chandra Pratap
2024-05-29 6:55 ` [GSoC][PATCH v2 1/4] t: move reftable/basics_test.c to the unit testing framework Chandra Pratap
2024-05-29 6:55 ` [GSoC][PATCH v2 2/4] t: move tests from reftable/stack_test.c to the new unit test Chandra Pratap
2024-05-29 6:55 ` [GSoC][PATCH v2 3/4] t: move tests from reftable/record_test.c " Chandra Pratap
2024-05-29 9:30 ` Patrick Steinhardt
2024-05-29 22:38 ` Junio C Hamano [this message]
2024-05-29 6:55 ` [GSoC][PATCH v2 4/4] t: add test for put_be16() and improve test-case for parse_names() Chandra Pratap
2024-05-29 9:30 ` Patrick Steinhardt
2024-05-29 9:29 ` [GSoC][PATCH v2 0/4] t: port reftable/basics_test.c to the unit testing Patrick Steinhardt
2024-05-29 16:59 ` [GSoC][PATCH v3 " Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 1/5] t: move reftable/basics_test.c to the unit testing framework Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 2/5] t: move tests from reftable/stack_test.c to the new unit test Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 3/5] t: move tests from reftable/record_test.c " Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 4/5] t: add test for put_be16() Chandra Pratap
2024-05-29 16:59 ` [GSoC][PATCH v3 5/5] t: improve the test-case for parse_names() Chandra Pratap
2024-05-30 4:35 ` [GSoC][PATCH v3 0/4] t: port reftable/basics_test.c to the unit testing Patrick Steinhardt
2024-05-30 7:52 ` Christian Couder
2024-05-30 14:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbk4otfae.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chandrapratap3519@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).