git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Heghedus Razvan <heghedus.razvan@protonmail.com>
Subject: Re: git init BUG when gitconfig has includeIf
Date: Tue, 21 May 2024 09:36:42 -0700	[thread overview]
Message-ID: <xmqqbk4zazqd.fsf@gitster.g> (raw)
In-Reply-To: <D1F5SJ52H4Z0.1NR7M8APRFTOB@protonmail.com> (Heghedus Razvan's message of "Tue, 21 May 2024 07:54:11 +0000")

Heghedus Razvan <heghedus.razvan@protonmail.com> writes:

> Yesterday I stumble upon a bug when doing git init. I didn't
> find any references to it, so I don't know if is a known problem
> or not.
>
> Steps to reproduce:
> # git init .
> BUG: refs.c:2123: reference backend is unknown

Patrick, this looks similar to an earlier one during "git clone"
that was discussed at

https://lore.kernel.org/git/72771da0-a0ef-4fd9-8071-6467cd7b6a6b@kernel-space.org/

that was fixed with 199f44cb (builtin/clone: allow remote helpers to
detect repo, 2024-02-27)?  The fix was about "git clone", but the
crux of the fix went to setup.c:initialize_repository_version()
which is also called by setup.c:init_db() that is the workhorse of
"git init", so it may already have been fixed (I didn't try).

Even if it is already fixed in the current version by the same
199f44cb, we may want to follow up 0eab85b9 (t5601: exercise clones
with "includeIf.*.onbranch", 2024-03-12) with an additional test to
cover "git init".

Thanks.

  reply	other threads:[~2024-05-21 16:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21  7:54 git init BUG when gitconfig has includeIf Heghedus Razvan
2024-05-21 16:36 ` Junio C Hamano [this message]
2024-05-21 16:46   ` Heghedus Razvan
2024-05-22  8:06     ` Patrick Steinhardt
2024-05-22  8:21       ` Heghedus Razvan
2024-05-22  8:27         ` Patrick Steinhardt
2024-05-22 10:38 ` [PATCH] setup: fix bug with "includeIf.onbranch" when initializing dir Patrick Steinhardt
2024-05-22 10:58   ` Heghedus Razvan
2024-05-22 19:06     ` Junio C Hamano
2024-05-23  0:41   ` Junio C Hamano
2024-05-23  5:26     ` Patrick Steinhardt
2024-05-23  0:43   ` [PATCH v2] " Junio C Hamano
2024-05-23  0:56     ` [rPATCH " Junio C Hamano
2024-05-23  5:26     ` [PATCH " Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbk4zazqd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=heghedus.razvan@protonmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).