From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Zach FettersMoore <zach.fetters@apollographql.com>,
Zach FettersMoore via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v6] subtree: fix split processing with multiple subtrees present
Date: Thu, 25 Jan 2024 10:56:09 -0800 [thread overview]
Message-ID: <xmqqbk99w8c6.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD2Oo8v8Qn0JPYURZA_s7ynZmk6v30b9zR==MxWBTXk9Ng@mail.gmail.com> (Christian Couder's message of "Thu, 25 Jan 2024 19:52:22 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> On Thu, Jan 25, 2024 at 5:38 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Christian Couder <christian.couder@gmail.com> writes:
>>
>> > It seems that this topic has fallen into the cracks or something,
>> > while the associated pch looks good to me.
>>
>> Yeah, it wasn't clear to me that your message you are responding to
>> was your Reviewed-by:. If I recall my impression correctly from the
>> time I skimmed its proposed log message the last time, it focused on
>> describing a single failure case the author encountered in the real
>> world and said that the patch changed the behaviour to correct that
>> single case, and was not very clear if it was meant as a general
>> fix. Is the patch text, including its proposed patch description,
>> satisfactory to you? In other words, is the above your Reviewed-by:?
>
> Yes, it's satisfactory for me, and I am Ok to give my Reviewed-by:, thanks!
Thanks. Will queue.
next prev parent reply other threads:[~2024-01-25 18:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 20:05 [PATCH] subtree: fix split processing with multiple subtrees present Zach FettersMoore via GitGitGadget
2023-09-18 23:31 ` Junio C Hamano
2023-09-19 1:04 ` Junio C Hamano
2023-10-26 19:59 ` Zach FettersMoore
2023-09-22 16:25 ` [PATCH v2 0/2] " Zach FettersMoore via GitGitGadget
2023-09-22 16:25 ` [PATCH v2 1/2] " Zach FettersMoore via GitGitGadget
2023-09-22 16:25 ` [PATCH v2 2/2] subtree: changing location of commit ignore processing Zach FettersMoore via GitGitGadget
2023-09-29 20:32 ` [PATCH v3 0/3] subtree: fix split processing with multiple subtrees present Zach FettersMoore via GitGitGadget
2023-09-29 20:32 ` [PATCH v3 1/3] " Zach FettersMoore via GitGitGadget
2023-09-29 20:32 ` [PATCH v3 2/3] subtree: changing location of commit ignore processing Zach FettersMoore via GitGitGadget
2023-09-29 20:33 ` [PATCH v3 3/3] subtree: adding test to validate fix Zach FettersMoore via GitGitGadget
2023-10-17 20:02 ` Zach FettersMoore
2023-10-26 19:17 ` [PATCH v4] subtree: fix split processing with multiple subtrees present Zach FettersMoore via GitGitGadget
2023-11-18 11:28 ` Christian Couder
2023-11-28 21:04 ` Zach FettersMoore
2023-11-28 21:17 ` [PATCH v5] " Zach FettersMoore via GitGitGadget
2023-11-30 20:33 ` Christian Couder
2023-11-30 21:01 ` Zach FettersMoore
2023-12-01 14:54 ` [PATCH v6] " Zach FettersMoore via GitGitGadget
2023-12-04 11:08 ` Christian Couder
2023-12-11 15:39 ` Zach FettersMoore
2023-12-12 16:06 ` Christian Couder
2023-12-12 22:28 ` Junio C Hamano
2023-12-13 15:20 ` Zach FettersMoore
2024-01-03 16:33 ` Christian Couder
2023-12-20 15:25 ` Christian Couder
2024-01-25 10:09 ` Christian Couder
2024-01-25 16:38 ` Junio C Hamano
2024-01-25 18:52 ` Christian Couder
2024-01-25 18:56 ` Junio C Hamano [this message]
2025-08-21 3:13 ` subtree: [v2.44 regression] split may produce different history Colin Stagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbk99w8c6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=zach.fetters@apollographql.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).