From: Junio C Hamano <gitster@pobox.com>
To: "Štěpán Němec" <stepnem@smrk.net>
Cc: Eric Sunshine <sunshine@sunshineco.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/5] Fix some typos, grammar or wording issues in the documentation
Date: Tue, 03 Oct 2023 14:10:02 -0700 [thread overview]
Message-ID: <xmqqbkdfxvit.fsf@gitster.g> (raw)
In-Reply-To: <20231003220951+0200.221551-stepnem@smrk.net> ("Štěpán Němec"'s message of "Tue, 03 Oct 2023 22:09:51 +0200")
Štěpán Němec <stepnem@smrk.net> writes:
> Come to think of it, 'doc: fix some typos, grammar and wording issues'
> might have made sense to begin with; I don't suppose C header comments
> are off-limits to doc:.
Yup, they do count as part of developer documentation.
>>> diff --git a/contrib/README b/contrib/README
>>> @@ -24,14 +24,14 @@ lesser degree various foreign SCM interfaces, so you know the
>>> I expect that things that start their life in the contrib/ area
>>> -to graduate out of contrib/ once they mature, either by becoming
>>> +graduate out of contrib/ once they mature, either by becoming
>>
>> You probably want to add a comma after "area".
>
> That would read awkward to me. How about going the other way,
>
> I expect things that start their life in the contrib/ area
> to graduate out of contrib/ once they mature
>
> instead?
That reads well. I do not recall whom "I" in this sentence refers
to, but if this were me talking about my wish, then yes, I expect
them to graduate once they mature, and the ">>>" quoted change to
drop "to" does not sound grammatical.
Thanks for working on improving the documentation, thanks for
reviewing, and thanks for working well together.
next prev parent reply other threads:[~2023-10-03 21:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 8:21 [PATCH 1/5] Fix some typos, grammar or wording issues in the documentation Štěpán Němec
2023-10-03 8:21 ` [PATCH 2/5] doc/diff-options: improve wording of the log.diffMerges mention Štěpán Němec
2023-10-03 8:21 ` [PATCH 3/5] git-jump: admit to passing merge mode args to ls-files Štěpán Němec
2023-10-03 18:33 ` Eric Sunshine
2023-10-03 20:15 ` Štěpán Němec
2023-10-03 20:46 ` Junio C Hamano
2023-10-03 21:01 ` Junio C Hamano
2023-10-03 8:21 ` [PATCH 4/5] doc/gitk: s/sticked/stuck/ Štěpán Němec
2023-10-03 8:21 ` [PATCH 5/5] t/README: fix multi-prerequisite example Štěpán Němec
2023-10-03 18:30 ` [PATCH 1/5] Fix some typos, grammar or wording issues in the documentation Eric Sunshine
2023-10-03 20:09 ` Štěpán Němec
2023-10-03 21:10 ` Junio C Hamano [this message]
2023-10-03 21:10 ` Eric Sunshine
2023-10-05 9:00 ` [PATCH v2 1/5] doc: fix some typos, grammar and wording issues Štěpán Němec
2023-10-05 9:00 ` [PATCH v2 2/5] doc/diff-options: improve wording of the log.diffMerges mention Štěpán Němec
2023-10-05 9:00 ` [PATCH v2 3/5] git-jump: admit to passing merge mode args to ls-files Štěpán Němec
2023-10-05 9:00 ` [PATCH v2 4/5] doc/gitk: s/sticked/stuck/ Štěpán Němec
2023-10-05 9:00 ` [PATCH v2 5/5] t/README: fix multi-prerequisite example Štěpán Němec
2023-10-05 20:17 ` [PATCH v2 1/5] doc: fix some typos, grammar and wording issues Junio C Hamano
2023-10-18 20:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbkdfxvit.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=stepnem@smrk.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).