From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff --stat: add config option to limit filename width
Date: Tue, 12 Sep 2023 10:11:40 -0700 [thread overview]
Message-ID: <xmqqbke7pb8z.fsf@gitster.g> (raw)
In-Reply-To: <487bd30e5a4cdcea8697393eb36ce3f3@manjaro.org> (Dragan Simic's message of "Tue, 12 Sep 2023 04:11:28 +0200")
Dragan Simic <dsimic@manjaro.org> writes:
>> Someday, as a follow-up after the dust from this topic settles, we
>> would probably want to look at how these rev.diffopt.* members are
>> initialized and refactor the common code out to a helper. It would
>> allow us to instead of doing this ...
>
> Another good point. If you agree, I'd prefer to have my patch
> accepted and merged as-is, ...
That is exactly what I meant by "follow-up after the dust settles".
All of the "we should probably do this and that in the future" are
called #leftoverbits comments. Food for thought, something people
can use to find inspiration for areas they may want to work on, that
has no impact to how "complete" the current patch being discussed
is.
next prev parent reply other threads:[~2023-09-12 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:39 [PATCH] diff --stat: add config option to limit filename width Dragan Simic
2023-09-11 23:12 ` Junio C Hamano
2023-09-12 2:11 ` Dragan Simic
2023-09-12 17:11 ` Junio C Hamano [this message]
2023-09-12 17:48 ` Dragan Simic
2023-09-16 2:09 ` Dragan Simic
2023-09-18 16:38 ` Junio C Hamano
2023-09-19 1:27 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbke7pb8z.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).