git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Han Young <hanyang.tony@bytedance.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] show doc: redirect user to git log manual instead of git diff-tree
Date: Wed, 06 Sep 2023 10:26:09 -0700	[thread overview]
Message-ID: <xmqqbkefnrgu.fsf@gitster.g> (raw)
In-Reply-To: <CAG1j3zFYbeXokd9kwN06RG7Wih_WsLVBf6jSi-JKtUpa=i4QJg@mail.gmail.com> (Han Young's message of "Tue, 5 Sep 2023 23:09:58 -0700")

Han Young <hanyang.tony@bytedance.com> writes:

>> Strictly speaking, "options to control how the changes are shown"
>> are options that are meant for "diff" command (e.g. "--stat", "-w"),
>> but "log" understands some of the "diff" command options, the
>> updated text is *not* incorrect.
>
> On a closer look, the manual page of git show does lists
> all the "diff" options by including diff-options.txt.
> The options omitted are revision parsing related.

The primary difference between "log" and "show" is that the latter
is not about walking a range of commits.  Both grok "diff" related
options that control how the changes introduced by each commit are
shown equally well.  But in the context of "show", options that
control revision traversal (i.e. which commits are chosen to be
shown and in what order) do not make much sense.

So ...

> Perhaps we remove the line
>
>> The command takes options applicable to the git diff-tree command to
>> control how the changes the commit introduces are shown.
>
> And rephrase the line
>
>> This manual page describes only the most frequently used options.
>
> to
>
>>  This manual page describes only the most frequently used options.
>> Some options that `git rev-list` command understands can be used to
>> control how commits are shown.

... I do not find the above an improvement.

Perhaps we should start with just "diff-tree" -> "log" and doing no
other damage to the existing text.  That will give us some baseline
that is a strict improvement.

Thanks.


  reply	other threads:[~2023-09-06 17:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 12:12 [PATCH] show doc: redirect user to git log manual instead of git diff-tree Han Young
2023-09-05 23:26 ` Junio C Hamano
2023-09-06  6:09   ` Han Young
2023-09-06 17:26     ` Junio C Hamano [this message]
2023-09-20 13:27 ` [PATCH v2] " Han Young
2023-09-20 15:52   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbkefnrgu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hanyang.tony@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).